Last modified: 2014-09-19 00:35:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70228, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 68228 - Gallery modes "packed-overlay" and "packed-hover" break the page
Gallery modes "packed-overlay" and "packed-hover" break the page
Status: RESOLVED DUPLICATE of bug 71030
Product: MobileFrontend
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-18 19:04 UTC by Steve
Modified: 2014-09-19 00:35 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Steve 2014-07-18 19:04:41 UTC
I'm running MediaWiki 1.23.1 and MobileFrontend master.

Below a gallery with mode="packed-overlay" or mode="packed-hover", subsequent top-level headers are nested within the section that the gallery is in. So if your sections are collapsed by default then you won't see subsequent sections unless you expand the section containing the gallery. It looks like this only happens in "phone" mode but the sections are normal in "tablet" mode.

In addition, the page footer does not load. This is true in both modes when a page contains a gallery with mode="packed-overlay" or mode="packed-hover".
Comment 1 Bingle 2014-07-18 19:05:22 UTC
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/5md53gEw
Comment 2 Florian 2014-07-18 20:07:01 UTC
Hello!

Thanks for fill this bug :)

I have tested it locally with MW 1.24 and latest master with this gallery code inside the first section (not main section :)):
<gallery mode="packed-hover">
File:Test2_2014-06-13_18-06.jpg|Hintergrund 1
File:Test2_2014-06-13_18-06.jpg|Hintergrund 2
File:Test2_2014-06-13_18-06.jpg|Hintergrund 3
File:Test2_2014-06-13_18-06.jpg|Hintergrund 4
</gallery>

And it worked with packed-hover and packed-overlay :/ Have you an example link to your wiki where it's not working? Maybe it's only on specific browsers? Which one you use? Which mobile device you test?
Comment 3 Steve 2014-07-18 20:33:37 UTC
Here is mode="packed-overlay":

http://www.halopedia.org/index.php?title=Armor_permutations_(Halo_4)&mobileaction=toggle_view_mobile

Here is mode="packed-hover":

http://www.halopedia.org/index.php?title=Hero_unit&mobileaction=toggle_view_mobile

I see now that the sections get messed up in the "tablet" view as well if you start closing them. It's definitely the source code - <div>'s and/or <li>'s are being left open.
Comment 4 Florian 2014-07-18 21:01:58 UTC
Still can't reproduce in MW1.24wmf14, will try with MW1.23 :)
Comment 5 Jon 2014-09-18 23:09:23 UTC
I too cannot reproduce it using packed galleries on mobile.

Looking at the source code of the page the footer is there but the gallery tag is not closed for some reason.

If you look at the desktop site this is also the case (run it through the w3c validator - http://validator.w3.org/check) so I'm guessing the issue is not with MobileFrontend but something to do with the gallery code.

Will take a deeper look and report findings.


Error Line 1535, Column 92: Unclosed element div.
…gallerybox" style="width: 170.666666667px"><div style="width: 170.666666667px">


If you look closely at the markup you'll notice a missing div inside each list item (see ???? where it should be)
<li class="gallerybox" style="width: 170.666666667px">
	<div style="width: 170.666666667px">
		<div class="thumb" style="width: 168.666666667px;">
			<div style="margin:0px auto;">
				<a href="/MJOLNIR_Powered_Assault_Armor/AA_variant"><img alt="" src="/images/thumb/0/06/H4_MJOLNIR_Air_Assault.png/253px-H4_MJOLNIR_Air_Assault.png" width="169" height="300" /></a>
			</div>
		</div>
		<div class="gallerytextwrapper" style="width: 149px">
			<div class="gallerytext">
				<p>Air Assault</p>
			</div>
		</div>
	????
</li>
Comment 6 Jon 2014-09-19 00:35:58 UTC
I've got a minimum test case now. Have reported it at bug 71030. It's not an issue in the mobile extension however.

*** This bug has been marked as a duplicate of bug 71030 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links