Last modified: 2014-07-24 19:54:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70287, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 68287 - Should not load full GuidedTour module unconditionally for all logged in users
Should not load full GuidedTour module unconditionally for all logged in users
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
ContentTranslation (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-07-19 23:13 UTC by Matthew Flaschen
Modified: 2014-07-24 19:54 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Matthew Flaschen 2014-07-19 23:13:02 UTC 
ContentTranslation should avoid loading the GuidedTour module unconditionally for all logged in users (https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FContentTranslation.git/0200e82dcc72575b96edba9be9951d0deaddc6db/ContentTranslation.hooks.php#L35).  It should only be loaded as needed.

There are probably multiple ways to do it (e.g. checking for the custom data cookie being present), but if we fix bug 68286, you will be able to use a similar API to the one you use currently, but without loading so much code.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links