Last modified: 2014-07-21 21:04:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70341, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 68341 - EventLogging dependency isn't so optional
EventLogging dependency isn't so optional
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Popups (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-07-21 21:04 UTC by Mark Holmquist
Modified: 2014-07-21 21:04 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Mark Holmquist 2014-07-21 21:04:56 UTC 
Looking through the code briefly, it looks like Popups conditionally loads the schema module that EL uses, but loads the ext.popups.eventlogging.js unconditionally and uses the functions defined there without any conditions as well.

I'd suggest putting a check for the EventLogging library in front of the call to mw.eventLog.logEvent() in that file...at the very least. Hopefully avoid loading the file at all if EL is turned off.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links