Last modified: 2014-07-23 20:54:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70344, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 68344 - IcuCollation's 'first-letters' cache key should include the version of ICU and possibly PHP that was used to build the data
IcuCollation's 'first-letters' cache key should include the version of ICU an...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Categories (Other open bugs)
1.24rc
All All
: High major (vote)
: ---
Assigned To: Nobody - You can work on this!
: hhvm
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-21 21:36 UTC by Bartosz Dziewoński
Modified: 2014-07-23 20:54 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bartosz Dziewoński 2014-07-21 21:36:56 UTC
IcuCollation's 'first-letters' cache key should include the version of ICU and possibly PHP that was used to build the data. Otherwise upgrading anything requires you to manually clear the caches.

I encountered this on Labs when preparing a test wiki for bug 54168 – it was set up under HHVM, then I switched to PHP 5.5 because page import doesn't work with HHVM (bug 66023), and then category listings got weird (http://i.imgur.com/Po94jiq.png for http://estonia.wmflabs.org/wiki/Kategooria:Test).

(The data is incompatible between different ICU versions, that's why we generate it dynamically in IcuCollation::getFirstLetterData() and cache instead of storing it in a static file somewhere.)

This is probably a blocker to the Trusty migration? Should be simple to fix.
Comment 1 Gerrit Notification Bot 2014-07-21 22:26:59 UTC
Change 148251 had a related patch set uploaded by Brian Wolff:
Include ICU version in cache key for collation first letters

https://gerrit.wikimedia.org/r/148251
Comment 2 Bawolff (Brian Wolff) 2014-07-21 22:28:45 UTC
I can't believe we don't already do this.

I'm not sure how hiphop implements intl though. Is INTL_ICU_VERSION still a constant in hiphop?
Comment 3 Kunal Mehta (Legoktm) 2014-07-22 02:18:39 UTC
(In reply to Bawolff (Brian Wolff) from comment #2)
> I'm not sure how hiphop implements intl though. Is INTL_ICU_VERSION still a
> constant in hiphop?

Using hhvm in vagrant: 
hphpd> var_dump(INTL_ICU_VERSION);
var_dump(INTL_ICU_VERSION);
string(7) "4.8.1.1"
Comment 4 Gerrit Notification Bot 2014-07-23 20:52:46 UTC
Change 148251 merged by jenkins-bot:
Include ICU version in cache key for collation first letters

https://gerrit.wikimedia.org/r/148251

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links