Last modified: 2014-10-28 19:29:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70371, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 68371 - Accessibility of headers broken due to accessibility enhancements
Accessibility of headers broken due to accessibility enhancements
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
: accessibility
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-22 11:17 UTC by Derk-Jan Hartman
Modified: 2014-10-28 19:29 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Derk-Jan Hartman 2014-07-22 11:17:11 UTC
The H2 headers in MF were recently enhanced to make their collapsibility more accessible (by Hoo ???). Because of this they now carry role="button".  This will break accessibility because it will override the default role of "heading" of the H2, which is not desirable. 

It should be role="heading button"
Comment 1 Bingle 2014-07-22 11:20:22 UTC
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/lIjuUOf0
Comment 2 Gerrit Notification Bot 2014-07-22 12:20:30 UTC
Change 148363 had a related patch set uploaded by Hoo man:
Make sure headings with role button also have the heading role

https://gerrit.wikimedia.org/r/148363
Comment 3 Jon 2014-09-16 23:31:48 UTC
Hoo man and TheDJ how can we get this patch wrapped up (I see theDJ -1ed it)?
Comment 4 Jon 2014-10-02 18:47:55 UTC
Releasing into wild.
Comment 5 Gerrit Notification Bot 2014-10-02 18:48:55 UTC
Change 148363 abandoned by Jdlrobson:
Make sure headings with role button also have the heading role

Reason:
Closing due to lack of activity. Please reopen this and resubmit it if you are still keen to fix this patch (someone else should feel free to fork it and fix it up).

https://gerrit.wikimedia.org/r/148363
Comment 6 Gerrit Notification Bot 2014-10-08 23:12:54 UTC
Change 148363 restored by Bmansurov:
Make sure headings with role button also have the heading role

Reason:
adding a new patch

https://gerrit.wikimedia.org/r/148363
Comment 7 Gerrit Notification Bot 2014-10-28 17:31:01 UTC
Change 148363 merged by jenkins-bot:
Remove role 'button'

https://gerrit.wikimedia.org/r/148363

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links