Last modified: 2014-07-25 14:44:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70401, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 68401 - iOS and Android: Fix EventLogging for abuse filter warning/disallow
iOS and Android: Fix EventLogging for abuse filter warning/disallow
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
General/Unknown (Other open bugs)
Beta
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-22 21:14 UTC by Dan Garry
Modified: 2014-07-25 14:44 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dan Garry 2014-07-22 21:14:41 UTC
I've been doing some analysis on the EventLogging data we have and I think that the app isn't reporting abuse filter triggers correctly.

Firstly, in the entire time the Android app has been out (nearly a month), I don't believe that the abuse filter has only been triggered 12 times. Especially considering we've been triggering it a lot ourselves to test it.

Secondly, when I triggered the abuse filter on both the current iOS beta and Android production builds, it triggered successfully, but yet no new row was created in the relevant table in the EventLogging database. The current Android Beta, however, did seem to increment the counter.

We should double-check that this data is correct, and that the EventLogging is hooked up correctly in both iOS and Android.
Comment 1 Brion Vibber 2014-07-24 20:45:10 UTC
iOS seems to have an error sending the wrong field names, which may be an issue there...

Also the EventLogging schema has been changed since what was implemented: https://meta.wikimedia.org/wiki/Schema:MobileWikiAppEdit shows rev 9113384 while we're listed as using rev 9003125 on both Android and iOS code... the only difference between those two versions appears to be a typo in a description, though, but I have no idea how picky the EL processing code is. :)
Comment 2 Gerrit Notification Bot 2014-07-24 21:21:49 UTC
Change 149125 had a related patch set uploaded by Brion VIBBER:
Fixing edit eventlogging for abuse filter

https://gerrit.wikimedia.org/r/149125
Comment 3 Brion Vibber 2014-07-24 21:24:14 UTC
With the patch, iOS seems to send events through intact from what I can see.
Comment 4 Gerrit Notification Bot 2014-07-25 02:34:16 UTC
Change 149125 merged by Mhurd:
Fixing edit eventlogging for abuse filter

https://gerrit.wikimedia.org/r/149125
Comment 5 Dmitry Brant 2014-07-25 14:34:57 UTC
From the Android point of view, the dearth of abuse filter events can be explained as follows:

The Android app was, in fact, not logging these events correctly until my patch on Jul 7 (https://gerrit.wikimedia.org/r/143024), which was after the first production release of the app.  Therefore it's only as of this week that the production version incorporates this change.

I can confirm, as we speak, that the events are being sent and received correctly now, using the latest production (and beta) version.
Comment 6 Dan Garry 2014-07-25 14:44:05 UTC
Then we can consider this resolved!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links