Last modified: 2014-08-13 11:08:48 UTC
* Open your browser's developer console to the Net tab. * visit a Flow board like http://en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow * Hover over the sort indicator ("Newest topics v" or "Recently active topics v") Result: 1. You don't see the tooltip for the sort. 2. Popups makes its API request for extracts|pageimages|revisions|info for the title "You are currently reading the newest topics first. ...", but there's (probably) no page with that title so it returns "missing". Expected: This link is <a href="javascript:void(0);" title="You are currently reading the newest topics first..." ...>. Popups should not bother with such a link. It looks like ext.popups.core.js setupTriggers() intends to exclude hrefs that start with '#' which is often the target for JavaScript enhancements; it needs similar code for hrefs that start with "javascript:" which fixes 2. However, by the time setupTriggers() is called, removeTooltips() has already blanked the title attribute, so the test needs to happen earlier.
Change 148583 had a related patch set uploaded by Spage: Don't render popup on "javascript:..." links. https://gerrit.wikimedia.org/r/148583
Change 148583 merged by Prtksxna: Don't render popup on "javascript:..." links. https://gerrit.wikimedia.org/r/148583
