Last modified: 2014-10-03 23:20:20 UTC
I tried editing a page. I pressed Save and received a little "Something went wrong" window. I pressed "Dismiss". I wanted to try saving again, but the "Save page" button was disabled. It should probably be re-enabled. VE Version: 234e4e6, on mediawiki.org.
I think we only show the error message for unrecoverable errors. Maybe we should prompt the user to give up rather than just exiting to an unusable save dialog?
ViewPageTarget#showSaveError allows errors to be recoverable or unrecoverable (defaulting to recoverable) The following errors should be recoverable: abusefilter badtoken The following errors are not: empty spamblacklist unknown Amir, what error did you run into?
Hmmmm, don't remember what it could be. Possibly badtoken.
Badtoken errors are automatically recovered from, though…
<Krenair> James_F, also, to clarify about badtoken - I was talking about saveErrorNewUser <Krenair> for invalid session <Krenair> it appears VE gets a new token to check whether the user ID has changed, when a badtoken error is encountered <RoanKattouw> Yeah we don't expose a badtoken error to the error handling code unless the API gave us a badtoken error twice <RoanKattouw> In which case the server's session storage is probably broken
I would mark this invalid until we could find out what error it would've been. But maybe we should make it clear in the UI when an error is unrecoverable (and have related patch(es) point to this bug).
