Last modified: 2014-07-30 23:38:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70479, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 68479 - Play button is over top of controls since z-index change
Play button is over top of controls since z-index change
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
TimedMediaHandler (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-07-23 21:28 UTC by Bawolff (Brian Wolff)
Modified: 2014-07-30 23:38 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Bawolff (Brian Wolff) 2014-07-23 21:28:13 UTC 
Since 3bc774a6ccb30ac6, there is now a giant play button over top of the play controls for audio files.

On one hand this kind of looks odd. On the other hand, the play button goes away on actually playing the file, so maybe its ok, a kind of button to "activate" the audio file. I don't know.

As for changing it, i guess we could also increase the z-index of the play controls, but where does it end with the z-indexes...


Example: https://commons.wikimedia.org/w/index.php?title=Commons:Sandbox&oldid=129716983
Comment 1 Brion Vibber 2014-07-23 21:54:44 UTC 
I've also seem some issues with those play buttons floating over other files' popup players, looks like related bad z-index to me.

See at https://commons.wikimedia.org/w/index.php?title=User:Brion_VIBBER/Demo&oldid=129720039 -- open one of the larger videos towards the bottom of the page.
Comment 2 Bawolff (Brian Wolff) 2014-07-24 01:55:21 UTC 
ich, that's much worse than the audio issue. Maybe 3bc774a6ccb30ac6 should be reverted. But having the play button not be clickable in a pop-up sucks quite a bit too. *sigh*
Comment 3 Gerrit Notification Bot 2014-07-29 18:12:13 UTC 
Change 150281 had a related patch set uploaded by Brian Wolff:
Revert "Make play button have higher z-index so its clickable."

https://gerrit.wikimedia.org/r/150281
Comment 4 Gerrit Notification Bot 2014-07-29 18:25:54 UTC 
Change 150285 had a related patch set uploaded by Brian Wolff:
Do not specify any z-index for the play button

https://gerrit.wikimedia.org/r/150285
Comment 5 Gerrit Notification Bot 2014-07-29 18:26:27 UTC 
Change 150281 abandoned by Brian Wolff:
Revert "Make play button have higher z-index so its clickable."

Reason:
Figured out a better solution (Gerrit change #150285)

https://gerrit.wikimedia.org/r/150281
Comment 6 Bawolff (Brian Wolff) 2014-07-29 18:32:13 UTC 
So apparently all z-index issues can be solved by just not messing with z-index in the first place (z-index: auto).
Comment 7 Gerrit Notification Bot 2014-07-29 22:38:03 UTC 
Change 150285 merged by jenkins-bot:
Do not specify any z-index for the play button

https://gerrit.wikimedia.org/r/150285
Comment 8 Gerrit Notification Bot 2014-07-30 18:32:22 UTC 
Change 150620 had a related patch set uploaded by Brian Wolff:
Do not specify any z-index for the play button

https://gerrit.wikimedia.org/r/150620
Comment 9 Gerrit Notification Bot 2014-07-30 19:06:41 UTC 
Change 150620 merged by jenkins-bot:
Do not specify any z-index for the play button

https://gerrit.wikimedia.org/r/150620
Comment 10 Bawolff (Brian Wolff) 2014-07-30 23:38:01 UTC 
this was just swat deployed. All fixed.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links