Last modified: 2014-08-21 20:40:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70484, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 68484 - VisualEditor: [Regression pre-wmf14] Each category is getting added twice in Betalabs, throws TypeError: categoryItem is undefined
VisualEditor: [Regression pre-wmf14] Each category is getting added twice in ...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High major
: VE-deploy-2014-08-14
Assigned To: Alex Monk
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-07-23 22:48 UTC by Rummana Yasmeen
Modified: 2014-08-21 20:40 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Screenshot (61.69 KB, image/png)
2014-07-23 22:48 UTC, Rummana Yasmeen 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2014-07-23 22:48:06 UTC 
Created attachment 16026 [details]
Screenshot

Steps to reproduce:

1.Open a page with VE
2.Go to Page Settings option>Categories
3.Try to add categories 

Observed Result:
After typing into a category name, it getting added twice and trying again throws error:

TypeError: categoryItem is undefined 

See the screenshot attached
Comment 1 Alex Monk 2014-07-25 18:56:56 UTC 
Can't reproduce...
Comment 2 James Forrester 2014-07-25 20:34:18 UTC 
Seems to be working again. Probably a deployment gremlin. Again. :-(
Comment 3 Rummana Yasmeen 2014-07-31 23:51:44 UTC 
Reproduced it today following these steps

1.Open a page with VE
2.Go to Page Settings option>Categories
3.Type a category name in the text field
4.When the drop down box appears, close the dialog
5.Again, reopen the Page Settings option>Categories
6.Now select a category from the drop down box

Observed Result:

It gets added twice,if you cancel the dialog box again it will throw the error:
TypeError: categoryItem is undefined 

If you reopen the Page Settings option>Categories, you will get stuck inside it.
Comment 4 Gerrit Notification Bot 2014-08-01 14:47:39 UTC 
Change 151088 had a related patch set uploaded by Alex Monk:
Tear down meta dialog pages when cancelling

https://gerrit.wikimedia.org/r/151088
Comment 5 Tomasz W. Kozlowski 2014-08-05 17:56:24 UTC 
The patch is not even merged yet, assuming the bug was closed by mistake.
Comment 6 Gerrit Notification Bot 2014-08-05 18:17:36 UTC 
Change 151088 merged by jenkins-bot:
Tear down meta dialog pages when cancelling

https://gerrit.wikimedia.org/r/151088
Comment 7 Alex Monk 2014-08-05 18:18:26 UTC 
Silly Gerrit.
Comment 8 Rummana Yasmeen 2014-08-05 19:34:33 UTC 
This is still happening on Betalabs
Comment 9 Alex Monk 2014-08-05 21:22:16 UTC 
Can now successfully reproduce on deployment-prep, but not my local wiki...
Comment 10 Rummana Yasmeen 2014-08-05 22:10:41 UTC 
Also, I am getting a different error this time while closing the dialog second time:
Uncaught TypeError: Cannot read property 'disconnect' of undefined
Comment 11 Alex Monk 2014-08-06 11:13:19 UTC 
And I can't reproduce it on deployment-prep any more. Rummana?
Comment 12 Rummana Yasmeen 2014-08-06 18:28:50 UTC 
Hmm, I can't either. Marking it as fixed.
Comment 13 Rummana Yasmeen 2014-08-14 21:23:34 UTC 
Verified the fix in test2
Comment 14 Rummana Yasmeen 2014-08-21 20:40:02 UTC 
Verified the fix in production
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links