Last modified: 2014-08-04 22:22:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70486, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 68486 - VisualEditor: Language dialog launched from inspector doesn't open in a global overlay


Summary:	VisualEditor: Language dialog launched from inspector doesn't open in a globa...

Status:	RESOLVED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	Editing Tools (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal minor
Target Milestone:	VE-deploy-2014-07-31
Assigned To:	Editing team bugs – take if you're interested!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-07-23 22:57 UTC by Ritu Swain
Modified:	2014-08-04 22:22 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ritu Swain 2014-07-23 22:57:58 UTC

Environment-test2

steps-

1> open a page in VE and open language inspector.
2> Click upon "English" in the inspector, to open the Language Selector dialog.
3> Now click on Language selector icon on top of the page, beside the username link (This extension is used for viewing pages in the language specified by the user's preferences).
4> Notice dialog saying "Select a Language" appears and the Language Inspector gets closed.But the Language Selector dialog(with two-letter code for languages) is still open.

Comment 1 Ed Sanders 2014-07-27 15:31:23 UTC

Those links at the top shouldn't be accessible when a dialog is open. The problem is that the language dialog is launched in a slightly different way to others because it is launched from an inspector, and isn't getting a 'global' overlay which would shield those links.

Comment 2 Gerrit Notification Bot 2014-07-27 15:34:49 UTC

Change 149635 had a related patch set uploaded by Esanders:
Make the overlay used by the language dialog global

https://gerrit.wikimedia.org/r/149635

Comment 3 Gerrit Notification Bot 2014-07-29 23:29:25 UTC

Change 149635 merged by jenkins-bot:
[BREAKING CHANGE] Fix ve.ui.Overlay classes

https://gerrit.wikimedia.org/r/149635

Comment 4 Ritu Swain 2014-08-01 19:08:36 UTC

Issue Resolved.

Comment 5 Rummana Yasmeen 2014-08-04 22:22:02 UTC

Hey Ritu, Can you specify the environment where you checked the fix?

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links