Last modified: 2014-09-11 02:59:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70492, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 68492 - VisualEditor: Don't use Range.detach (is now a no-op in Chrome per revised DOM spec)
VisualEditor: Don't use Range.detach (is now a no-op in Chrome per revised DO...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: Low major
: VE-deploy-2014-09-11
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-07-24 02:06 UTC by Krinkle
Modified: 2014-09-11 02:59 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Krinkle 2014-07-24 02:06:29 UTC 
Chrome emits this notice when using VisualEditor anywhere.

> 'Range.detach' is now a no-op, as per DOM (http://dom.spec.whatwg.org/#dom-range-detach).


Looks like more than the typical deprecation, because it's been replaced with a no-op. No idea if we/Rangy are relying on it doing something. Could cause all kinds of weird state inconsistencies.
Comment 1 Tim Down 2014-08-01 23:09:22 UTC 
Rangy has no reliance on Range.detach now. The latest release does not use it at all.
Comment 2 Roan Kattouw 2014-08-01 23:33:09 UTC 
(In reply to Tim Down from comment #1)
> Rangy has no reliance on Range.detach now. The latest release does not use
> it at all.
Unfortunately we still use the Rangy position plugin, which appears to have been unmaintained for a while. So we're stuck with our current version of rangy for now. Ideally I would like us to migrate away from the position plugin, then to a more recent version of Rangy. But I need to do a code audit to see is being used where.
Comment 3 James Forrester 2014-09-11 02:59:01 UTC 
As we've now dumped Rangy, this is now FIXED.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links