Last modified: 2014-08-27 13:49:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70507, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 68507 - replication lag may affect recurrent reports
replication lag may affect recurrent reports
Status: RESOLVED FIXED
Product: Analytics
Classification: Unclassified
Wikimetrics (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: christian
u=AnalyticsEng c=Wikimetrics p=8 s=20...
:
Depends on:
Blocks: 69252
  Show dependency treegraph
 
Reported: 2014-07-24 12:30 UTC by Dan Andreescu
Modified: 2014-08-27 13:49 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dan Andreescu 2014-07-24 12:30:22 UTC
If labsdb has replication lag (which I'm not 100% sure is possible), then recurrent reports might not see all the data for a given day when they run.  That means that data would go missing from any run, because reports use database timestamps and recurrent report runs use actual time.  Example:

* day X starts
* edit 1
* edit 2
* replication lag means the rest of day X is not on labsdb yet
* edit 3
* day X ends
* recurrent report runs for day X, gets data from labsdb, and doesn't see edit 3.
...
* recurrent report runs for day X+1 and the timestamp range filter means it doesn't see edit 3.

result: day X edit totals are off and never corrected.
Comment 1 Kevin Leduc 2014-08-07 19:40:03 UTC
Collaborative tasking on etherpad:
http://etherpad.wikimedia.org/p/analytics-68507
Comment 2 nuria 2014-08-14 10:01:52 UTC
Per conversation with springle this table will be in db  information_schema_p which is present of every host and has open access.

Information on lag will be reported per shard (s1, s2...)
Comment 3 christian 2014-08-15 12:46:53 UTC
As the title limits to recurrent reports (although the same issue also
affects non-recurrent reports), I am assuming that we really only need
to cover recurrent reports.
Comment 4 Dan Andreescu 2014-08-15 12:48:36 UTC
That's a fine assumption.  The mechanism we use to determine replag could be reused later.  And for now, people running ad-hoc reports are probably used to replag the same way that people run ad-hoc queries.
Comment 5 Gerrit Notification Bot 2014-08-15 13:45:43 UTC
Change 154267 had a related patch set uploaded by QChris:
Reschedule recurring reports to 03:00

https://gerrit.wikimedia.org/r/154267
Comment 6 Gerrit Notification Bot 2014-08-18 14:53:16 UTC
Change 154267 merged by Milimetric:
Reschedule recurring reports to 03:00

https://gerrit.wikimedia.org/r/154267
Comment 7 Gerrit Notification Bot 2014-08-19 10:32:50 UTC
Change 155003 had a related patch set uploaded by QChris:
Stop scheduling new recurrent runs if databases lag

https://gerrit.wikimedia.org/r/155003
Comment 8 Gerrit Notification Bot 2014-08-25 19:50:51 UTC
Change 155003 merged by Milimetric:
Stop scheduling new recurrent runs if databases lag

https://gerrit.wikimedia.org/r/155003
Comment 9 christian 2014-08-27 13:49:11 UTC
All relevant changes have been merged.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links