Last modified: 2014-08-14 20:21:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70546, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 68546 - VisualEditor Mobile: MobileContext is not in the DOM
VisualEditor Mobile: MobileContext is not in the DOM
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Mobile (Other open bugs)
unspecified
All All
: Highest major
: VE-deploy-2014-07-31
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-07-25 00:34 UTC by Juliusz Gonera
Modified: 2014-08-14 20:21 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Juliusz Gonera 2014-07-25 00:34:48 UTC 
When running VE on mobile, in the console:

$('.ve-ui-context')
[]
$('.ve-ui-mobileContext')
[]

I thought that the context not appearing on mobile was a CSS regression but it seems it's no longer attached to the DOM. Too tired today to figure out why (or to figure out how DesktopContext is attached to DOM).
Comment 1 Gerrit Notification Bot 2014-07-25 18:10:45 UTC 
Change 149356 had a related patch set uploaded by Catrope:
[WIP] Attach mobile surface to the toolbar

https://gerrit.wikimedia.org/r/149356
Comment 2 Gerrit Notification Bot 2014-07-25 23:24:23 UTC 
Change 149356 merged by jenkins-bot:
Attach mobile surface to the toolbar

https://gerrit.wikimedia.org/r/149356
Comment 3 Rummana Yasmeen 2014-08-04 22:09:32 UTC 
Verified the fix in Betalabs and test2
Comment 4 Rummana Yasmeen 2014-08-14 20:21:21 UTC 
Verified the fix in production
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links