Last modified: 2014-11-12 15:06:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70579, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 68579 - iOS & Android: MobileFrontend styles unconditionally adding borders to tables
iOS & Android: MobileFrontend styles unconditionally adding borders to tables
Status: NEW
Product: Wikipedia App
Classification: Unclassified
General/Unknown (Other open bugs)
Alpha
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-07-25 17:43 UTC by Brion Vibber
Modified: 2014-11-12 15:06 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Are we talking about the table attached? (178.07 KB, image/png)
2014-10-02 18:15 UTC, Bahodir Mansurov 		Details
World War II article table with borders but no content. (178.14 KB, image/png)
2014-10-10 00:27 UTC, Monte Hurd 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Brion Vibber 2014-07-25 17:43:03 UTC 
styles.css unconditionally adds borders on tables in the content area. This causes oddities in some cases where tables are used for layout (they shouldn't be, but they are!)

For example the infobox template used on [[World War II]] adds an extra surrounding table if the 'campaignbox' parameter is used, which it is here. This adds an extra box around the infobox on MobileFrontend, and in the Android and iOS apps it creates an extra visible box that ends up sitting above the infobox because we move the infobox down out of where it was.
Comment 1 Ryan Kaldari 2014-09-26 18:31:42 UTC 
Maybe tables within infoboxes shouldn't get automatic borders.
Comment 2 Bahodir Mansurov 2014-10-02 18:15:01 UTC 
Created attachment 16647 [details]
Are we talking about the table attached?
Comment 3 Ryan Kaldari 2014-10-06 21:06:21 UTC 
Bahodir: Yes, I believe so.
Comment 4 Gerrit Notification Bot 2014-10-06 22:12:41 UTC 
Change 165120 had a related patch set uploaded by Bmansurov:
Remove borders from tables within infoboxes

https://gerrit.wikimedia.org/r/165120
Comment 5 Gerrit Notification Bot 2014-10-07 21:40:18 UTC 
Change 165120 merged by jenkins-bot:
Remove borders from tables within infoboxes

https://gerrit.wikimedia.org/r/165120
Comment 6 Monte Hurd 2014-10-10 00:27:37 UTC 
Created attachment 16740 [details]
World War II article table with borders but no content.

The tables like the one in the attached image are very mysterious...
Comment 7 Andre Klapper 2014-11-12 15:06:03 UTC 
Resetting bug report status from PATCH_TO_REVIEW to NEW as there are no patches left to review.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links