Last modified: 2014-07-29 00:28:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70677, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 68677 - VisualEditor: Typing over a link doesn't undo correctly
VisualEditor: Typing over a link doesn't undo correctly
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2014-07-31
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-07-27 13:15 UTC by Ed Sanders
Modified: 2014-07-29 00:28 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ed Sanders 2014-07-27 13:15:53 UTC 
1. Select a link fully
2. Type one letter
3. Press undo

Observer the first letter of the link is no longer linked.
Comment 1 Gerrit Notification Bot 2014-07-27 14:57:31 UTC 
Change 149633 had a related patch set uploaded by Esanders:
Copy annotation indexes before returning

https://gerrit.wikimedia.org/r/149633
Comment 2 Ed Sanders 2014-07-27 15:05:13 UTC 
The cause here is that the removal data in the transaction gets modified by annotationSet.removeAt(). Now the recorded removal data doesn't match the actual data that was there. If you created that link in this session then you also have have a sequence of transactions that don't connect.
Comment 3 Gerrit Notification Bot 2014-07-28 21:57:13 UTC 
Change 149633 merged by jenkins-bot:
Copy annotation indexes before returning

https://gerrit.wikimedia.org/r/149633
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links