Last modified: 2014-08-05 04:22:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70694, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 68694 - category add breaks when adding category to redirect
category add breaks when adding category to redirect
Status: RESOLVED FIXED
Product: Pywikibot
Classification: Unclassified
category.py (Other open bugs)
unspecified
All All
: Unprioritized major
: ---
Assigned To: Fabian
backport_required
: code-update-regression
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-07-27 22:23 UTC by John Mark Vandenberg
Modified: 2014-08-05 04:22 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description John Mark Vandenberg 2014-07-27 22:23:29 UTC 
(bug report extracted from https://gerrit.wikimedia.org/r/#/c/149638)

category.py AddCategory attempts to find the redirect target in exception IsRedirectPage.args[0]

IsRedirectError stopped having args[0] in March 2009 for core, when Exception.__init__ was overriden, and in early 2010 for compat when the core class was copied to compat
https://git.wikimedia.org/blobdiff/pywikibot%2Fcore.git/c471da5bfbfc12898c289d0fd83bdd2447386159/pywikibot%2Fexceptions.py
http://git.wikimedia.org/commit/pywikibot%2Fcompat.git/94ee284da270e0760b5e0ccfbe37ec96d8d79713

I couldnt see any other use of 'args[0]' in core or compat that is the same bug.
Comment 1 Ricordisamoa 2014-08-05 03:12:10 UTC 
Found in compat, too.
Comment 2 Gerrit Notification Bot 2014-08-05 03:14:09 UTC 
Change 151811 had a related patch set uploaded by Ricordisamoa:
backport Ibd85350cda6b511afd3b7a335abe20bd4ac0899e from core

https://gerrit.wikimedia.org/r/151811
Comment 3 Gerrit Notification Bot 2014-08-05 03:38:41 UTC 
Change 151811 merged by jenkins-bot:
backport Ibd85350cda6b511afd3b7a335abe20bd4ac0899e from core

https://gerrit.wikimedia.org/r/151811
Comment 4 Ricordisamoa 2014-08-05 04:22:41 UTC 
https://gerrit.wikimedia.org/r/149638 for core,
https://gerrit.wikimedia.org/r/151811 for compat.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links