Last modified: 2014-08-19 19:44:58 UTC
Created attachment 16053 [details] Reply • thank Reply and thank buttons should be quiet buttons. On hover, reply should be grey instead of blue. But thank can stay green on hover.
in backlog: https://trello.com/c/i0JbNqWf
I think using core's mw-ui- CSS styles instead of independent flow-ui- styles has introduced unwanted changes to Reply button appearance. Compare en-wiki's "flow-ui-progressive flow-ui-quiet" (good) with mw.org's "mw-ui-button mw-ui-progressive mw-ui-quiet flow-ui-inline" (bold, indented, and spaced too far apart). Flow's version of Agora buttons let us apply x-ui-progressive and x-ui-quiet alone, without x-ui-button making the text bold and surrounded by unwanted button padding. But on mw.org if I remove the mw-ui-button stying then the Reply • Edit • Thank buttons don't have the right hover behavior: they're blue all the time and get an underline on hover. (In reply to May from comment #0) > On hover, reply should be grey instead of blue. Why? The Living style guide says "Use progressive buttons for actions which lead to a next step in the process" which seems to apply to Reply. What's special about Reply that we want to de-emphasize it even on hover?
Created attachment 16073 [details] Compare latest buttons with older CSS on enwiki
flow-ui-inline is not getting applied anymore. This is an easy fix.
Change 150112 had a related patch set uploaded by Spage: Load ext.flow.mediawiki.ui.buttons module https://gerrit.wikimedia.org/r/150112
Blue is meant for progressive actions within a workflow. For example in a sign in form, you fill in your details (already within a workflow) and then blue or green to move on to next or finish workflow. Every button is actionable, so if it makes sense for a button not within a workflow to be blue, it seems like to me every other button can be blue. For reply, which basically brings up a workflow, is not a progressive action. It's more like a start a workflow action, which as of now is grey.
Change 148724 had a related patch set uploaded by Jdlrobson: Constructive colour watchstar https://gerrit.wikimedia.org/r/148724
Change 150112 abandoned by Jdlrobson: Load ext.flow.mediawiki.ui.buttons module Reason: Hopefully this is clearer now. This module no longer exists. Sorry for confusion! https://gerrit.wikimedia.org/r/150112
Change 148724 abandoned by Jdlrobson: Constructive colour watchstar Reason: Rewritten inhttps://gerrit.wikimedia.org/r/#/c/150577/ https://gerrit.wikimedia.org/r/148724
The appearance is fixed. Reply still turns blue. In reply to May from comment #6 > For reply, which basically brings up a workflow, is not a progressive > action. It's more like a start a workflow action, which as of now is grey. Jared and May concluded starting a workflow *is* blue (mw-ui-progressive). Gray (mw-ui-quiet only) is for e.g. a link that goes somewhere with no necessary next step, such as View history or Permalink. We will clarify the Living Style Guide http://tools.wmflabs.org/styleguide/desktop/
