Last modified: 2014-09-26 06:24:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70720, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 68720 - beta: ResourceLoader CSS URL gzipped twice, causing skins to be broken
beta: ResourceLoader CSS URL gzipped twice, causing skins to be broken
Status: RESOLVED FIXED
Product: Wikimedia Labs
Classification: Unclassified
deployment-prep (beta) (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
: hhvm
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-28 09:22 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-09-26 06:24 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2014-07-28 09:22:08 UTC
One of the CSS resource loader URL yield content which is gzipped twice :-(

The content is shown by piping to gzcat twice:

curl 'http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=7Cext.uls.nojs%7Cext.visualEditor.viewPageTarget.noscript%7Cext.wikihiero%7Cmediawiki.legacy.commonPrint%2Cshared%7Cmediawiki.skinning.interface%7Cmediawiki.ui.button%7Cskins.vector.styles%7Cwikibase.client.init&only=styles&skin=vector&*'|gzcat|gzcat

Headers:

> User-Agent: curl/7.30.0
> Host: bits.beta.wmflabs.org
> Accept: */*
> 
< HTTP/1.1 200 OK
* Server Apache is not blacklisted
< Server: Apache
< Access-Control-Allow-Origin: *
< Expires: Mon, 28 Jul 2014 09:22:53 GMT
< X-Content-Type-Options: nosniff
< Content-Encoding: gzip, gzip
< X-Powered-By: HHVM/3.3.0-dev
< Cache-control: public, max-age=300, s-maxage=300
< Vary: Accept-Encoding
< Last-Modified: Thu, 24 Jul 2014 03:43:51 GMT
< Content-Type: text/css; charset=utf-8
< Content-Length: 24050
< Accept-Ranges: bytes
< Date: Mon, 28 Jul 2014 09:19:08 GMT



Same goes on when passing Accept-Encoding: gzip

I restarted varnish on the bits cache to clear up the bits cache, hasn't solved anything.


The minified CSS cache key is enwiki:resourceloader:filter:minify-css:7:e07e6ad07840d291e66cf3fe9f0980c3
Comment 2 Antoine "hashar" Musso (WMF) 2014-07-28 15:24:38 UTC
Niklas reported it to be fixed in Vagrant:

 hhvm: set GzipCompressionLevel = 0 to avoid double-gzip
 https://gerrit.wikimedia.org/r/#/c/145771/

Which was bug 67928
Comment 3 Ori Livneh 2014-09-26 06:24:35 UTC
Fixed in 4bdfea04cea2e54e6076a1c6b955ba1e1b51209f.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links