Last modified: 2014-08-02 12:00:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70767, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 68767 - AbuseFilter should display a more useful message instead of "An unknown error occurred."


Summary:	AbuseFilter should display a more useful message instead of "An unknown error...

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	AbuseFilter (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	easy, javascript

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-07-28 21:03 UTC by Helder
Modified:	2014-08-02 12:00 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Helder 2014-07-28 21:03:05 UTC

If I try to calculate the result of applying ccnorm to a long string (e.g. 9000 x 'a', or a typical value of the added_lines variable), I get the message "An unknown error occurred." but there is more information in the console:

"mw.Api error: " "http" Object { xhr: Object, textStatus: "error", exception: "Request-URI Too Large" }

My suggestion is to provide a more informative message for the user in this case.

Comment 1 Gerrit Notification Bot 2014-07-28 23:21:20 UTC

Change 150080 had a related patch set uploaded by Helder.wiki:
Use POST method for action=abusefilterevalexpression API requests

https://gerrit.wikimedia.org/r/150080

Comment 2 Gerrit Notification Bot 2014-07-28 23:24:56 UTC

Change 150080 merged by jenkins-bot:
Use POST method for action=abusefilterevalexpression API requests

https://gerrit.wikimedia.org/r/150080

Comment 3 Andre Klapper 2014-07-30 09:52:57 UTC

Helder: Does your merged patch fix this, or is more work needed?

Comment 4 Helder 2014-07-30 14:32:17 UTC

We need a little more. The previous patch just avoid that specific HTTP error from happening, but there could be others, and it would be useful to expose the exact information to the user if it is available. I'll submit another patch in a few minutes.

Comment 5 Gerrit Notification Bot 2014-07-30 14:49:13 UTC

Change 150557 had a related patch set uploaded by Helder.wiki:
Improve error handling for HTTP requests

https://gerrit.wikimedia.org/r/150557

Comment 6 Gerrit Notification Bot 2014-08-02 12:00:23 UTC

Change 150557 merged by jenkins-bot:
Improve error handling for HTTP requests

https://gerrit.wikimedia.org/r/150557

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links