Last modified: 2014-10-31 19:54:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70780, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 68780 - [scap] "UnicodeDecodeError: 'ascii' codec can't decode byte" when announcing sync result to irc
[scap] "UnicodeDecodeError: 'ascii' codec can't decode byte" when announcing ...
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Deployment systems (Other open bugs)
wmf-deployment
All All
: Normal normal (vote)
: ---
Assigned To: Bryan Davis
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-29 03:14 UTC by Bryan Davis
Modified: 2014-10-31 19:54 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bryan Davis 2014-07-29 03:14:36 UTC
Reported by Araron when running `sync-file php-1.24wmf15/includes/specials/SpecialWhatlinkshere.php` [0] :

02:38:33 Finished sync-apaches (duration: 00m 06s)
02:38:33 Unhandled error:
Traceback (most recent call last):
  File "/srv/deployment/scap/scap/scap/cli.py", line 262, in run
    exit_status = app.main(extra_args)
  File "/srv/deployment/scap/scap/scap/main.py", line 366, in main
    super(SyncFile, self).main(*extra_args)
  File "/srv/deployment/scap/scap/scap/main.py", line 67, in main
    self._after_lock_release()
  File "/srv/deployment/scap/scap/scap/main.py", line 397, in _after_lock_release
    utils.human_duration(self.get_duration()))
  File "/srv/deployment/scap/scap/scap/cli.py", line 80, in announce
    self._announce_logger.info(*args)
  File "/usr/lib/python2.7/logging/__init__.py", line 1140, in info
    self._log(INFO, msg, args, **kwargs)
  File "/usr/lib/python2.7/logging/__init__.py", line 1258, in _log
    self.handle(record)
  File "/usr/lib/python2.7/logging/__init__.py", line 1268, in handle
    self.callHandlers(record)
  File "/usr/lib/python2.7/logging/__init__.py", line 1308, in callHandlers
    hdlr.handle(record)
  File "/usr/lib/python2.7/logging/__init__.py", line 748, in handle
    self.emit(record)
  File "/srv/deployment/scap/scap/scap/log.py", line 81, in emit
    sock.sendall(message.encode('utf-8'))
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 82: ordinal not in range(128)
02:38:33 sync-file failed: <UnicodeDecodeError> 'ascii' codec can't decode byte 0xc2 in position 82: ordinal not in range(128)



[0]: https://github.com/wikimedia/mediawiki-core/blob/0dc906423d9109461559a41970bd77fa6c35b7ff/includes/specials/SpecialWhatlinkshere.php
Comment 1 Bryan Davis 2014-07-29 03:24:45 UTC
Aaron clarified that the command he ran was literally `sync-file php-1.24wmf15/includes/specials/SpecialWhatlinkshere.php 0dc906423d9109461559a41970bd77fa6c35b7ff`. Additionally he reports that `sync-file php-1.24wmf15/includes/specials/SpecialWhatlinkshere.php 'no-op scap test'` is failing in the same way.
Comment 2 Mark Holmquist 2014-09-02 15:23:11 UTC
I just ran a sync-file that gave me this error:

15:16:25 sync-file failed: <UnicodeDecodeError> 'ascii' codec can't decode byte 0xc3 in position 124: ordinal not in range(128)

I was attempting to use this message:

'[SCAP] Enable the TemplateData GUI editor on Norwegian Bokmål Wikipedia'

So it's absolutely right that ASCII can't decode that character, but maybe we should be using Unicode, 'cuz languages 'n' stuff.
Comment 3 Gerrit Notification Bot 2014-10-31 04:16:46 UTC
Change 170282 had a related patch set uploaded by BryanDavis:
Don't encode() non-unicode strings

https://gerrit.wikimedia.org/r/170282
Comment 4 Gerrit Notification Bot 2014-10-31 19:24:49 UTC
Change 170282 merged by jenkins-bot:
Don't encode() non-unicode strings

https://gerrit.wikimedia.org/r/170282
Comment 5 Bryan Davis 2014-10-31 19:54:11 UTC
$ /usr/local/bin/wmf-beta-scap 'Testing with unicode ☃'
Starting ssh-agent
Agent pid 6624
Identity added: /var/lib/mwdeploy/.ssh/id_rsa (/var/lib/mwdeploy/.ssh/id_rsa)
19:52:09 Started scap: Testing with unicode ☃
19:52:09 Copying to deployment-bastion.eqiad.wmflabs from deployment-bastion.eqiad.wmflabs
19:52:09 Started rsync common
19:52:13 Finished rsync common (duration: 00m 03s)
19:52:13 Compiled /srv/mediawiki/wikiversions-labs.json to /srv/mediawiki/wikiversions-labs.cdb
19:52:13 Started mw-update-l10n
19:52:13 Updating ExtensionMessages-master.php
19:52:14 Updating LocalisationCache for master using 2 thread(s)
19:52:19 Generating JSON versions and md5 files
19:52:21 Finished mw-update-l10n (duration: 00m 07s)
19:52:21 Started cache_git_info
19:52:33 Finished cache_git_info (duration: 00m 11s)
19:52:33 Started sync-proxies
sync-proxies: 100% (ok: 1; fail: 0; left: 0)
19:52:45 Finished sync-proxies (duration: 00m 12s)
19:52:45 Started sync-apaches
sync-common: 100% (ok: 6; fail: 0; left: 0)
19:53:04 Finished sync-apaches (duration: 00m 18s)
19:53:04 Started scap-rebuild-cdbs
scap-rebuild-cdbs: 100% (ok: 7; fail: 0; left: 0)
19:53:08 Finished scap-rebuild-cdbs (duration: 00m 04s)
19:53:08 Started sync_wikiversions
19:53:08 Compiled /srv/mediawiki-staging/wikiversions-labs.json to /srv/mediawiki-staging/wikiversions-labs.cdb
sync_wikiversions: 100% (ok: 7; fail: 0; left: 0)
19:53:11 Finished sync_wikiversions (duration: 00m 03s)
hhvm_restart: 100% (ok: 7; fail: 0; left: 0)
19:53:14 Finished scap: Testing with unicode ☃ (duration: 01m 05s)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links