Last modified: 2014-07-29 21:57:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70784, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 68784 - CentralAuth tests are failing
CentralAuth tests are failing
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralAuth (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-29 04:49 UTC by Kunal Mehta (Legoktm)
Modified: 2014-07-29 21:57 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Kunal Mehta (Legoktm) 2014-07-29 04:49:21 UTC
https://integration.wikimedia.org/ci/job/mwext-CentralAuth-testextensions-master/191/console

04:46:15 1) CentralAuthHooksUsingDatabaseTest::testOnAbortNewAccount with data set #0 (UserNotExists, true)
04:46:15 Use of User::crypt was deprecated in MediaWiki 1.23. [Called from CentralAuthTestUser::__construct in /srv/ssd/jenkins-slave/workspace/mwext-CentralAuth-testextensions-master/extensions/CentralAuth/tests/CentralAuthTestUser.php at line 97]

04:46:15 2) CentralAuthPluginUsingDatabaseTest::testAuthenticate with data set #0 ('GlobalUser', 'GUP@ssword', true, 'Valid login for attached global')
04:46:15 Use of User::comparePasswords was deprecated in MediaWiki 1.23. [Called from CentralAuthUser::matchHash in /srv/ssd/jenkins-slave/workspace/mwext-CentralAuth-testextensions-master/extensions/CentralAuth/CentralAuthUser.php at line 1531]
Comment 1 Gerrit Notification Bot 2014-07-29 05:00:17 UTC
Change 150138 had a related patch set uploaded by Legoktm:
Stop using deprecated User::comparePasswords/User::crypt

https://gerrit.wikimedia.org/r/150138
Comment 2 Kunal Mehta (Legoktm) 2014-07-29 05:04:58 UTC
Other option is to remove the wfDeprecated calls from those two functions until CentralAuth is updated accordingly.
Comment 3 Chris Steipp 2014-07-29 13:35:59 UTC
I actually already had Gerrit change #141482 ready, which would also fix this, and checks for password upgrades. We should be fine doing either one right now.
Comment 4 Gerrit Notification Bot 2014-07-29 15:00:22 UTC
Change 150138 abandoned by Legoktm:
Stop using deprecated User::comparePasswords/User::crypt

Reason:
https://gerrit.wikimedia.org/r/#/c/141482/ is better

https://gerrit.wikimedia.org/r/150138
Comment 5 Gerrit Notification Bot 2014-07-29 15:00:40 UTC
Change 141482 had a related patch set uploaded by Legoktm:
Update CentralAuth for Password API

https://gerrit.wikimedia.org/r/141482
Comment 6 Gerrit Notification Bot 2014-07-29 17:35:12 UTC
Change 141482 merged by jenkins-bot:
Update CentralAuth for Password API

https://gerrit.wikimedia.org/r/141482

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links