Last modified: 2014-08-01 19:25:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70808, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 68808 - VisualEditor: Language Inspector is not opening in the caption of the Media Settings dialog when in insertion mode (because dm.document's this.lang is null).


Summary:	VisualEditor: Language Inspector is not opening in the caption of the Media S...

Status:	RESOLVED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	Editing Tools (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal
Target Milestone:	VE-deploy-2014-07-31
Assigned To:	James Forrester

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-07-29 15:51 UTC by Ritu Swain
Modified:	2014-08-01 19:25 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	Google Chrome
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
screenshot1 (96.97 KB, image/png) 2014-07-29 15:51 UTC, Ritu Swain	Details
screenshot2 (96.58 KB, image/png) 2014-07-29 15:51 UTC, Ritu Swain	Details
screenshot (101.24 KB, image/png) 2014-08-01 19:25 UTC, Ritu Swain	Details
Add an attachment (proposed patch, testcase, etc.)

Description Ritu Swain 2014-07-29 15:51:30 UTC

Created attachment 16088 [details]
screenshot1

Environment- test2

Steps-
1> open a page in VE.
2> Insert ->Media. 
3>Select to add a media file. Opens the Media Settings dialog.
4>Now click on “Caption” pane and Select Language from the text style menu, closes the drop down.
5>Cursor is at the beginning of the line. Click again on the style text menu to see that the Language is selected . See screenshots.
6> Notice typing the first letter deselects the Language from the drop-down, and so the language inspector never appears.

Comment 1 Ritu Swain 2014-07-29 15:51:58 UTC

Created attachment 16089 [details]
screenshot2

Comment 2 James Forrester 2014-07-29 16:16:36 UTC

Ed, is this fixed by Gerrit change #149635?

Comment 3 Ritu Swain 2014-07-29 16:52:48 UTC

 baehavior found in betalabs.

Comment 4 Gerrit Notification Bot 2014-07-31 00:00:17 UTC

Change 150738 had a related patch set uploaded by Jforrester:
Set a default language for ve.dm.Document if we can't guess it otherwise

https://gerrit.wikimedia.org/r/150738

Comment 5 James Forrester 2014-07-31 00:01:09 UTC

This is… interesting.

Comment 6 Gerrit Notification Bot 2014-07-31 00:05:33 UTC

Change 150738 merged by jenkins-bot:
Set a default language for ve.dm.Document if we can't guess it otherwise

https://gerrit.wikimedia.org/r/150738

Comment 7 Ritu Swain 2014-08-01 19:24:26 UTC

In Chrome and FF only the Language Inspector appears out of place when launched for the first time.The steps to reproduce are the same.See screenshot.Both in test2 and beta.

Comment 8 Ritu Swain 2014-08-01 19:25:05 UTC

Created attachment 16121 [details]
screenshot

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links