Last modified: 2014-08-20 20:22:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70891, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 68891 - MediaWiki 1.24wmf6 required when trying to install VisualEditor_REL1.23
MediaWiki 1.24wmf6 required when trying to install VisualEditor_REL1.23
Status: RESOLVED WORKSFORME
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-31 00:47 UTC by MarkJurgens
Modified: 2014-08-20 20:22 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MarkJurgens 2014-07-31 00:47:30 UTC
A number of people trying to install 1.23.1 + VE + Parsoid are finding an error that crashes the site.

https://www.mediawiki.org/wiki/Extension_talk:VisualEditor#MediaWiki_1.24wmf6_required_when_trying_to_install_VisualEditor_REL1.23_45012


I'm also experiencing it, here's the error messaging:


[d64ccb4d] /wiki/ Exception from line 3279 of /home/mywiki/public_html/wiki/includes/GlobalFunctions.php: MediaWiki 1.24wmf6 required--this is only 1.23.1

Backtrace:

#0 /home/mywiki/public_html/wiki/extensions/VisualEditor/VisualEditor.hooks.php(23): wfUseMW(string)
#1 [internal function]: VisualEditorHooks::onSetup()
#2 /home/mywiki/public_html/wiki/includes/Setup.php(601): call_user_func(string)
#3 /home/mywiki/public_html/wiki/includes/WebStart.php(156): require_once(string)
#4 /home/mywiki/public_html/wiki/index.php(43): require(string)
#5 {main}
Comment 1 Krinkle 2014-07-31 15:06:11 UTC
If they installed VisualEditor master, than that is bound to fail because it requires 1.24alpha (as all extensions do unless otherwise noted).

There is a REL1_23 branch[1] which requires 1.22 or higher (not 1.24alpha).

It seems however that the custom 1.23 download made available is packages from some arbitrary version not documented anywhere and that version contains "wfUseMW( '1.24wmf6' );" in its code.

I suggest whatever hacks were applied to produce this tarball are applied to REL1_23 following regular code review. If it's based on master instead of REL1_23, we can fast-forward REL1_23 to master and apply the fixes then.

Either way whatever we promote as 1.23-compat should be git and go through review. And when it does, it should be fixed to not require wfUseMW( '1.24wmf6' ); which is a bit silly for code explicitly made for 1.23.

[1] https://github.com/wikimedia/mediawiki-extensions-VisualEditor/tree/REL1_23
[2] https://www.mediawiki.org/wiki/Extension:VisualEditor
Comment 2 Kunal Mehta (Legoktm) 2014-08-20 19:35:23 UTC
I just downloaded the latest tarball from <https://www.mediawiki.org/wiki/Special:ExtensionDistributor?extdist_extension=VisualEditor&extdist_version=REL1_23&extdist_submit=Continue>, and I see wmfUseMW( '1.22' ) in it.
Comment 3 James Forrester 2014-08-20 20:22:04 UTC
This sounds like the creation of the temporary tarball was very broken, but thanks to Kunal's work on ExtensionDistributor this should now be moot. Sorry for the troubles.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links