Last modified: 2014-07-31 13:47:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70901, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 68901 - VisualEditor: State of 'Save' button stops being updated after opening and cancelling the "Options" dialog


Summary:	VisualEditor: State of 'Save' button stops being updated after opening and ca...

Status:	RESOLVED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	Editing Tools (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High major
Target Milestone:	VE-deploy-2014-07-31
Assigned To:	Bartosz Dziewoński

URL:
Whiteboard:
Keywords:	code-update-regression

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-07-31 06:54 UTC by Juan de Vojníkov
Modified:	2014-07-31 13:47 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Shows that redirect page Save page (=Uložit stránku) is gray (47.62 KB, image/jpeg) 2014-07-31 06:54 UTC, Juan de Vojníkov	Details
Add an attachment (proposed patch, testcase, etc.)

Description Juan de Vojníkov 2014-07-31 06:54:36 UTC

Created attachment 16108 [details]
Shows that redirect page Save page (=Uložit stránku) is gray

In this case, I am adding a template to the redirect page (delete template), but I cannot safe it. The safe button stay gray (attachment).

Steps to reproduce this bug (Windows Vista, FF 31.0):
1) open https://cs.wikipedia.org/w/index.php?title=Cristina_Fern%C3%A1ndez_de_Kirchner&redirect=no
2) click on Edit
3) Cencel options
4) Insert > Template > Smazat (Add more information: 1; randoom text) > Insert template
5) Save page = but you cannot!

Comment 1 Bartosz Dziewoński 2014-07-31 07:07:17 UTC

Indeed.

In step 4), it also suffices to just input any text – the "Save" button doesn't become enabled.

However, if in step 3) you click "Apply changes" rather than "Cancel", everything works correctly.

Comment 2 Bartosz Dziewoński 2014-07-31 07:28:27 UTC

It gets better: the state of the 'Save' button stops being updated always when you open the "Options" dialog and cancel it instead of applying.

Comment 3 Gerrit Notification Bot 2014-07-31 07:30:18 UTC

Change 150772 had a related patch set uploaded by Bartosz Dziewoński:
ve.ui.MWMetaDialog: Really *ALWAYS* return to normal tracking behavior

https://gerrit.wikimedia.org/r/150772

Comment 4 Gerrit Notification Bot 2014-07-31 07:51:29 UTC

Change 150772 merged by jenkins-bot:
ve.ui.MWMetaDialog: Really *ALWAYS* return to normal tracking behavior

https://gerrit.wikimedia.org/r/150772

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links