Last modified: 2014-08-11 09:48:55 UTC
To avoid bugs like bug 66182, there should be a check for executable rights on text files and image files or for all files, when there would never be executable files in wikimedia git. Thanks.
You can of course install your own pre-commit hook to do so, but git does not allow to automatically install hooks. But one could add such guards to Jenkins, if that's desired. Hence, moving to the "Continuous integration" component.
There is a hook, which rejectes patch sets without valid Change-Id, the same is needed here, maybe call it post-commit hook or server-commit hook, but that is wat is needed to avoid having these files in gerrit. To avoid merge of this, you can use jenkins, but not all repos having jenkins running.
(In reply to db from comment #2) > There is a hook, which rejectes patch sets without valid Change-Id, the same > is needed here, maybe call it post-commit hook or server-commit hook, but > that is wat is needed to avoid having these files in gerrit. To avoid merge > of this, you can use jenkins, but not all repos having jenkins running. That's not a hook. It's a piece of functionality in Gerrit. I have no intentions of hacking Gerrit for this when Jenkins will do just fine. If Jenkins isn't running on a repo then add it.
