Last modified: 2014-11-18 00:54:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70916, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 68916 - VisualEditor: Toolbar should update fixed position after resize if MediaWiki layout changed (e.g. Vector skin goes below 982px SD/HD boundary)
VisualEditor: Toolbar should update fixed position after resize if MediaWiki ...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal minor
: VE-deploy-2014-10-29 (1.25wmf6)
Assigned To: Ed Sanders
: code-update-regression
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-31 12:08 UTC by Krinkle
Modified: 2014-11-18 00:54 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of bug. (210.08 KB, image/png)
2014-07-31 12:09 UTC, Krinkle
Details

Description Krinkle 2014-07-31 12:08:14 UTC
When resizing the window, after a certain point the MediaWiki page layout may change (media queries). This affects the offset from the left side of the page (specifically, width of the sidebar).

However the toolbar caches its computed offset once and never updates it.

1. Open window wider than 1024px with Vector skin in MediaWiki.
2. Enter VisualEditor.
3. Resize to < 980px.

Expected:

Sidebar shrinks (per Vector styles) and toolbar should still align with left edge of the page.

Actual:

Sidebar shrinks but toolbar stays behind causing an awkward gap to appear as well as odd interruption in the shadow. It results in part of the Save page button to go off-screen. 

Other:

The reverse happens as well. Opening a narrow window and scaling it up will cause it to stay behind in the other direction. It results in part of the toolbar overlapping links in the sidebar.
Comment 1 Krinkle 2014-07-31 12:09:55 UTC
Created attachment 16109 [details]
Screenshot of bug.
Comment 2 Gerrit Notification Bot 2014-10-27 22:10:22 UTC
Change 169232 had a related patch set uploaded by Esanders:
Recalculate toolbar size on window resize

https://gerrit.wikimedia.org/r/169232
Comment 3 Gerrit Notification Bot 2014-10-27 22:16:17 UTC
Change 169232 merged by jenkins-bot:
Recalculate toolbar size on window resize

https://gerrit.wikimedia.org/r/169232
Comment 4 etonkovidova 2014-11-18 00:54:53 UTC
Verified the fix in production.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links