Last modified: 2014-08-19 08:52:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71014, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69014 - [PhpTagsFunctions] Fatal error: Unexpected object type stdClass. in PhpTagsFunc.php on line 20
[PhpTagsFunctions] Fatal error: Unexpected object type stdClass. in PhpTagsFu...
Status: ASSIGNED
Product: MediaWiki extensions
Classification: Unclassified
Other (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Pavel (pastakhov)
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-01 17:23 UTC by Nemo
Modified: 2014-08-19 08:52 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nemo 2014-08-01 17:23:45 UTC
Fatal error: Unexpected object type stdClass. in /srv/vagrant/mediawiki/extensions/PhpTagsFunctions/includes/PhpTagsFunc.php on line 20

Under hhvm/hiphop; tests with php5 didn't go as far as needed to tell whether it's hhvm-specific. (Is the dot a typo?)
Comment 1 Pavel (pastakhov) 2014-08-18 03:13:04 UTC
I have all the tests pass successfully.
Can you recheck it for the current version?

I checked with PhpTag v 3.4.2 and PhpTags Functions v 3.2.3 in HHVM on Vagrant.
Comment 2 Pavel (pastakhov) 2014-08-18 03:32:03 UTC
oops. I had the wrong tests. A lot of tests in PhpTags Functions under HHVM  isn't passing. I'll fix it.
Comment 3 Pavel (pastakhov) 2014-08-19 08:52:11 UTC
For the correct operation is required to describe number and type of parameters for each function. Because the extension contains a lot of functions it will take a lot of time which I do not have yet. As a temporary way out I decided not to validate the data that the users pass to the functions and catch errors using the function set_error_handler.

The problem is the error handler in HHVM is too different of Zend.
And the main problem is that the wrong expression 
> php -r 'echo date_format(5, "Y-m-d");'

Zend returns:
PHP Warning:  date_format() expects parameter 1 to be DateTime, integer given in Command line code on line 1
And it can be continued.

But HHVM returns:
Fatal error: Unexpected object type stdClass. in /tmp/php-wrap-dFLaAw on line 2
And it can not be continued.

I will solve this problem, but it will not be very soon.
Thanks for the bug report.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links