Last modified: 2014-09-01 12:13:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71040, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69040 - Agora .mw-ui-input focus indicator uses a different blue from colorProgressive
Agora .mw-ui-input focus indicator uses a different blue from colorProgressive
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
MediaWiki UI (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Shahyar Ghobadpour
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-02 04:22 UTC by spage
Modified: 2014-09-01 12:13 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-08-02 04:22:13 UTC
The comment for the "left bar" focus indicator recently merged to core in the style guide (http://tools.wmflabs.org/styleguide/desktop/section-1.html) is "When focused a progressive highlight appears to the left of the field."

But the hardcoded color for the left box-shadow in resources/src/mediawiki.ui/components/inputs.less is #5088f7, which isn't colorProgressive (#347bff).  It's lighter and more washed-out.

Flow originally used #347bff for the focus indicator.  Shahyar's prototype of new UI ideas used #5088f7, Flow switched to that value in April with template rendering, and that's been the color ever since.  FWIW both the .png in the Trello card https://trello.com/c/8FOi1X1x/16-basic-input-field and the original Agora_specs.pdf use #4C85FB without actually specifying a color.

If we want a different color for the focus indicator we should derive it from colorProgressive using LESS color operations, and modify the comment in the CSS.
Comment 1 Gerrit Notification Bot 2014-08-28 18:53:27 UTC
Change 156839 had a related patch set uploaded by Jdlrobson:
Use correct progressive color on inputs

https://gerrit.wikimedia.org/r/156839
Comment 2 Gerrit Notification Bot 2014-09-01 12:13:22 UTC
Change 156839 merged by jenkins-bot:
Use correct progressive color on inputs

https://gerrit.wikimedia.org/r/156839

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links