Last modified: 2014-08-14 17:37:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71082, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69082 - Gerrit change #146683 broke `php tests/parserTests.php`.
Gerrit 146683 broke `php tests/parserTests.php`.
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Unit tests (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Aaron Schulz
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-03 21:38 UTC by C. Scott Ananian
Modified: 2014-08-14 17:37 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description C. Scott Ananian 2014-08-03 21:38:45 UTC
`git bisect` shows that gerrit patch https://gerrit.wikimedia.org/r/146683 broke `php tests/parserTests.php`.

$ php tests/parserTests.php --quiet
This is MediaWiki version 1.24alpha (4c0871f).

A database error has occurred. Did you forget to run maintenance/update.php after upgrading?  See: https://www.mediawiki.org/wiki/Manual:Upgrading#Run_the_update_script
Query: DELETE FROM `parsertest_l10n_cache` WHERE lc_lang = 'en'
Function: LCStoreDB::finishWrite
Error: 1146 Table 'mediawiki-dev.parsertest_l10n_cache' doesn't exist (localhost)
PHP Notice:  Uncommitted DB writes (transaction from LocalFile::recordUpload2). in /home/cananian/Projects/Wikimedia/core/includes/db/Database.php on line 4188
PHP Notice:  Uncommitted DB writes (transaction from LCStoreDB::finishWrite). in /home/cananian/Projects/Wikimedia/core/includes/db/Database.php on line 4188
$

(Running maintenance/update.php has no effect)

Umherirrender says, "This breaks parser tests, because the new db connection has the wrong prefix. CloneDatabase needs a callback in the LBFactory for new connections?"
Comment 1 Gerrit Notification Bot 2014-08-03 21:42:04 UTC
Change 151522 had a related patch set uploaded by Cscott:
Revert "Made LCStoreDB try to use a separate DB connection"

https://gerrit.wikimedia.org/r/151522
Comment 2 Gerrit Notification Bot 2014-08-13 21:01:39 UTC
Change 151522 merged by jenkins-bot:
Revert "Made LCStoreDB try to use a separate DB connection"

https://gerrit.wikimedia.org/r/151522

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links