Last modified: 2014-11-01 01:48:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71119, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69119 - VisualEditor: Undoing a change of group on a reference throws "Uncaught TypeError: Cannot read property 'length' of undefined"
VisualEditor: Undoing a change of group on a reference throws "Uncaught TypeE...
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: Low major
: VE-deploy-nextup
Assigned To: Ed Sanders
:
: 69125 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-04 19:16 UTC by Ritu Swain
Modified: 2014-11-01 01:48 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
screenshot (86.92 KB, image/png)
2014-08-04 19:16 UTC, Ritu Swain
Details

Description Ritu Swain 2014-08-04 19:16:41 UTC
Created attachment 16136 [details]
screenshot

Environment-test,production, beta.

Steps-
1> Open a page with at least three different citations(book, news,journal).
2>select the “basic” citation and use any existing reference. The reference gets added.
3>Now while the reference is still highlighted, select “Basic” citation again. Type some text in “Use this Group” and apply changes.
5>Notice the citation is replaced by the text that was put in the “Use this Group” and is highlighted.
6> Now click to undo at least 2-3 times.
7> Notice now the tools in the editor toolbar behave oddly , for ex- link does not get added,the language text is not highlighted ,lists  do not get added.


Same problem was found in Chrome,Safari and FF.See screenshot.

In FF JS Console error is-

TypeError:KeyedNodes is undefined
Error: Unbalanced input passed to document.
Comment 1 Alex Monk 2014-08-04 21:36:36 UTC
(In reply to Ritu Swain from comment #0)
> 1> Open a page with at least three different citations(book, news,journal).
> 2>select the “basic” citation and use any existing reference. The reference
> gets added.

What? We only have book, news and journal at this point... No basic...
Comment 2 Ritu Swain 2014-08-04 23:45:09 UTC
(In reply to Alex Monk from comment #1)
> (In reply to Ritu Swain from comment #0)
> > 1> Open a page with at least three different citations(book, news,journal).
> > 2>select the “basic” citation and use any existing reference. The reference
> > gets added.
> 
> What? We only have book, news and journal at this point... No basic...
My apologies for the confusion.Here are the steps-

1> Open a page with at least three different citations(book, news,journal).
2> select to add the “basic” citation and choose to use any existing reference. The reference gets added.
3> Now while the reference is still highlighted, select to add “Basic” citation again. When the dialog opens,type some text in “Use this Group” and apply changes.
5> Notice the citation is replaced by the text that was put in the “Use this Group” and is highlighted.
6> Now click to undo at least 2-3 times.
7> Notice now the tools in the editor toolbar behave oddly , for ex- link does not get added,the language text is not highlighted and lists  do not get added.
Comment 3 Alex Monk 2014-08-05 15:06:36 UTC
Is this the same thing?
* Make a basic reference, apply changes
* Go back and give it a non-blank group, apply changes
* Undo a few times
* Uncaught TypeError: Cannot read property 'length' of undefined
(which is related to but not quite the same as bug 69125)
Comment 4 Ritu Swain 2014-08-05 15:26:04 UTC
(In reply to Alex Monk from comment #3)
> Is this the same thing?
> * Make a basic reference, apply changes
> * Go back and give it a non-blank group, apply changes
> * Undo a few times
> * Uncaught TypeError: Cannot read property 'length' of undefined
> (which is related to but not quite the same as bug 69125)

in Chrome JS Console- i get this error
 
Uncaught TypeError: Cannot read property 'length' of undefined.
Error: Unbalanced input passed to document.

in FF JS Console error is-
TypeError:KeyedNodes is undefined
Error: Unbalanced input passed to document.

after this, the tools in the toolbar when accessed behave weirdly.
Comment 5 Alex Monk 2014-08-05 15:28:51 UTC
Yes, but is that the same issue you were talking about in this bug?
Comment 6 Ritu Swain 2014-08-05 15:43:55 UTC
yes, it is the same issue.
Comment 7 Alex Monk 2014-10-02 00:22:25 UTC
Seems to be caused by the internal list not being (properly?) updated when undoing a group change (it stores references by group name).
Comment 8 Alex Monk 2014-11-01 01:48:44 UTC
*** Bug 69125 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links