Last modified: 2014-10-21 22:45:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71122, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 69122 - VisualEditor: [Regression wmf16] Opening link inspector/comment box in an empty line, opens them at the end of the previous line
VisualEditor: [Regression wmf16] Opening link inspector/comment box in an emp...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-09-04
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-08-04 20:31 UTC by Rummana Yasmeen
Modified: 2014-10-21 22:45 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Screenshot (111.35 KB, image/png)
2014-08-04 20:31 UTC, Rummana Yasmeen 		Details
Screenshot (33.61 KB, image/png)
2014-08-26 18:31 UTC, Rummana Yasmeen 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2014-08-04 20:31:45 UTC 
Created attachment 16137 [details]
Screenshot

Steps to reproduce:

1.Open a page with mobile VE
2.Go to the end of a line
3.Press return to go the next line and click on link inspector or comment icon from the toolbar

Observed Result:
The link inspector and the comment box opens at the end of the previous line
After adding a link or a comment it appears on the next line though.


See the screenshot attached

Environment:Betalabs and test2
Comment 1 Alex Monk 2014-08-05 15:37:03 UTC 
(In reply to Rummana Yasmeen from comment #0)
> Created attachment 16137 [details]
> Screenshot
> 
> Steps to reproduce:
> 
> 1.Open a page with mobile VE

That screenshot does not appear to be from a mobile device...
Comment 2 Rummana Yasmeen 2014-08-05 18:15:35 UTC 
Right Alex :) This bug is not for mobile VE but for desktop. Sorry about that!
Comment 3 Rummana Yasmeen 2014-08-06 20:01:07 UTC 
Language inspector also behaves in the same way
Comment 4 James Forrester 2014-08-13 18:10:15 UTC 
Yeah, selection is going very wonky here.
Comment 5 Gerrit Notification Bot 2014-08-21 20:06:14 UTC 
Change 155619 had a related patch set uploaded by Esanders:
Fallback to node position when getting selection rectangle

https://gerrit.wikimedia.org/r/155619
Comment 6 Gerrit Notification Bot 2014-08-21 20:26:13 UTC 
Change 155619 merged by jenkins-bot:
Fallback to node position when getting selection rectangle

https://gerrit.wikimedia.org/r/155619
Comment 7 Rummana Yasmeen 2014-08-26 18:31:52 UTC 
Created attachment 16282 [details]
Screenshot

This is still happening,the inspectors are now opening not at the end of previous line, but somewhere along the preceding 4/5 lines 

See the screenshot attached, where I tried to add a link inside the bullet list and it appears at some position in page title.
Comment 8 Gerrit Notification Bot 2014-09-02 19:49:16 UTC 
Change 157868 had a related patch set uploaded by Catrope:
Don't use three different coordinate systems in getSelectionRect()

https://gerrit.wikimedia.org/r/157868
Comment 9 Gerrit Notification Bot 2014-09-04 00:03:42 UTC 
Change 157868 merged by jenkins-bot:
Don't use three different coordinate systems in getSelectionRect()

https://gerrit.wikimedia.org/r/157868
Comment 10 Rummana Yasmeen 2014-09-04 18:46:23 UTC 
Verified the fix in betalabs
Comment 11 Rummana Yasmeen 2014-09-04 23:09:29 UTC 
Verified the fix in test2
Comment 12 Rummana Yasmeen 2014-09-12 18:10:28 UTC 
Verified the fix in Betalabs
Comment 13 Rummana Yasmeen 2014-09-12 18:11:01 UTC 
*Verified the fix in production*
Comment 14 Rummana Yasmeen 2014-09-15 19:32:48 UTC 
This is again happening for comment box in Betalabs
Comment 15 Rummana Yasmeen 2014-09-15 21:28:48 UTC 
(In reply to Rummana Yasmeen from comment #14)
> This is again happening for both link inspector and comment box in Betalabs
Comment 16 Alex Monk 2014-10-21 21:18:45 UTC 
Can't reproduce...
Comment 17 Rummana Yasmeen 2014-10-21 22:45:52 UTC 
Got fixed with Ed's selection re-write I believe? I have not seen it happening recently too.Marking as fixed
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links