Last modified: 2014-08-07 12:42:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71207, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69207 - Parsoid: Interwiki links are halfway converted to external links, and completely broken
Parsoid: Interwiki links are halfway converted to external links, and complet...
Status: NEW
Product: Parsoid
Classification: Unclassified
serializer (Other open bugs)
unspecified
All All
: Normal major
: ---
Assigned To: Parsoid Team
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-06 22:49 UTC by WhatamIdoing
Modified: 2014-08-07 12:42 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description WhatamIdoing 2014-08-06 22:49:49 UTC
http://en.wikipedia.beta.wmflabs.org/w/index.php?diff=118689&oldid=101159

This took a perfectly normal link like:

[[mw:User talk:Whatamidoing (WMF)|on Mediawiki]]

and turned it into something completely broken (single brackets instead of double, and space instead of pipe):

[mw:User talk:Whatamidoing (WMF) on Mediawiki]
Comment 1 WhatamIdoing 2014-08-06 22:50:43 UTC
Also, I didn't touch any of those links.  I added a space in one paragraph so I could look at the Save dialog, and it broke all of these interwiki links on the entire page.
Comment 2 James Forrester 2014-08-07 07:04:45 UTC
Ick. Regression?
Comment 3 ssastry 2014-08-07 11:11:13 UTC
I cannot reproduce this on http://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:Whatamidoing_(WMF)/Sandbox&oldid=101159 when I try to edit again.

However, I can reproduce it locally on the commandline if a data-parsoid flag is removed.

[subbu@earth lib] echo '[[mw:User talk:Whatamidoing (WMF)|on Mediawiki]]' | node parse | sed 's/"isIW":true,//g;' | node parse --html2wt
[mw:User talk:Whatamidoing (WMF) on Mediawiki]

So, it is unclear how this might have happened. Clearly, the original and modified HTML differed on all these links for them to get re-serialized and because of the missing attribute in data-parsoid, the serialization breaks.

Could this have been a transient VE bug that clobbered data-parsoid somehow?
Comment 4 ssastry 2014-08-07 12:42:43 UTC
Unrelated to the bug report: we'll probably make our link handling code more robust since we can recover most information without the flag being present. This is part of the general link handling cleanup that needs to happen in Parsoid.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links