Last modified: 2014-08-24 19:16:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71219, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69219 - The ":" char in a definition list should be parsed differently depending on html-tag context it is found in.
The ":" char in a definition list should be parsed differently depending on h...
Status: ASSIGNED
Product: Parsoid
Classification: Unclassified
tokenizer (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Arlo Breault
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-07 10:10 UTC by Roan Kattouw
Modified: 2014-08-24 19:16 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2014-08-07 10:10:36 UTC
See e.g. http://parsoid-lb.eqiad.wikimedia.org/wikimania2014wiki/Submissions%2FVisualEditor_%E2%80%94_engineering_against_the_odds?oldid=47825 vs https://wikimania2014.wikimedia.org/wiki/Submissions/VisualEditor_%E2%80%94_engineering_against_the_odds?oldid=47825

Wikitext:

; '''Sunday August 10, 12:30, [[Frobisher 123]]'''

Parsoid HTML:

<dl><dt> <b>Sunday August 10, 12</b></dt><dd><b>30, <a rel="mw:WikiLink" href="./Frobisher_123">Frobisher 123</a></b></dd></dl>


PHP parser HTML:

<dl><dt><b>Sunday August 10, 12:30, <a href="/wiki/Frobisher_123" title="Frobisher 123">Frobisher 123</a></b></dt></dl>

It looks like this might be a syntax ambiguity, but hopefully we can have bug-for-bug compatibility with the PHP parser? :)
Comment 1 Roan Kattouw 2014-08-07 10:12:26 UTC
Also, if you try to edit this, the resulting wikitext is something like '''Sunday August 10, 11''':30, [[Frobisher 123]]''' . It's trying to close the bolding twice.
Comment 2 ssastry 2014-08-07 10:31:45 UTC
Thankfully, this is not related to time, but more related to context-sensitive tokenization of the ":" char in a dt-dl list.

;a:b
;''a:b''

The behavior require a bit more testing. Ideally, this is reasonably well-behaved that it can be fixed in the tokenizer without requiring a DOM transformation fixup.
Comment 3 Gerrit Notification Bot 2014-08-23 05:08:45 UTC
Change 155868 had a related patch set uploaded by Arlolra:
b/i context aware parsing of definition list colon

https://gerrit.wikimedia.org/r/155868
Comment 4 ssastry 2014-08-24 19:16:46 UTC
Updating the title to reflect that this is not just i/b wikitext context, but more general. As indicated in comment 2, this could use some more testing to better spec out what the right behavior is.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links