Last modified: 2014-10-17 11:46:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71221, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69221 - Flow: no-JS "cancel" buttons also submit the form
Flow: no-JS "cancel" buttons also submit the form
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-07 10:22 UTC by Matthias Mullie
Modified: 2014-10-17 11:46 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthias Mullie 2014-08-07 10:22:22 UTC
We're using <button>s for Cancel. There's some javascript that will properly destroy the forms when that button is clicked, but without JS, that button will also submit the form. That's probably not what you'd expect when you hit cancel.

We probably just want to hide those buttons if users run Flow without JS, like:

    .client-nojs button[data-role=cancel] {
        display: none;
    }
Comment 1 Gerrit Notification Bot 2014-08-07 10:25:21 UTC
Change 152241 had a related patch set uploaded by Matthias Mullie:
(bug 69221) Hide cancel <button>s for no-js

https://gerrit.wikimedia.org/r/152241
Comment 2 Gerrit Notification Bot 2014-08-07 20:16:25 UTC
Change 152241 merged by jenkins-bot:
(bug 69221) Hide cancel <button>s for no-js

https://gerrit.wikimedia.org/r/152241
Comment 3 Andre Klapper 2014-10-17 11:46:20 UTC
Patch was merged - assuming this bug is FIXED. If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links