Last modified: 2014-09-02 09:10:31 UTC
As reported at https://zh.wikivoyage.org/wiki/Wikivoyage:%E4%BA%92%E5%8A%A9%E5%AE%A2%E6%A0%88#.E4.B8.8A.E9.9D.A2.E7.9A.84.E5.91.8A.E7.A4.BA.E6.B2.92.E6.9C.89.E8.BD.89.E6.8F.9B.E6.AD.A3.E3.80.81.E7.B0.A1.E9.AB.94.E4.B8.AD.E6.96.87 , even if the user language and user language variant are changed, sitenotice still appears to be the same: * https://zh.wikivoyage.org/zh-hans/Special:Blankpage?zh-hans * https://zh.wikivoyage.org/zh-hant/Special:Blankpage?zh-hant After some research, I've found out that in https://github.com/wikimedia/mediawiki-core/blob/6f022809880ed9ae330045b76723f9d14601916e/includes/Skin.php#L1552 , $needParse partly depends on whether [[MediaWiki:Sitenotice]] was actually changed. However, language converter works within the parser, which means that even if the wikitext was the same, after parsing, the text could actually change. It is recently that the variant of the cached version changed from zh to zh-tw, and some non-hant users have found that the sitenotice became unreadable for them. As shown in https://github.com/wikimedia/mediawiki-core/blob/6f022809880ed9ae330045b76723f9d14601916e/includes/Skin.php#L1549 , a change to $wgRenderHashAppend (which defaults to '') could re-parse the page. And due to above issues, I propose to append the variant name $wgRenderHashAppend while processing sitenotice.
Correction: * https://zh.wikivoyage.org/zh-hans/Special:Blankpage?uselang=zh-hans * https://zh.wikivoyage.org/zh-hant/Special:Blankpage?uselang=zh-hant
Change 156026 had a related patch set uploaded by Zhuyifei1999: Add language code to sitenotice cache key https://gerrit.wikimedia.org/r/156026
Change 156026 abandoned by Zhuyifei1999: Add language code to sitenotice cache key https://gerrit.wikimedia.org/r/156026
