Last modified: 2014-10-07 17:09:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71304, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69304 - Android app doesn't support language variants in UI translations
Android app doesn't support language variants in UI translations
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
Android App (Other open bugs)
Stable
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
: 69457 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-08 16:39 UTC by Dmitry Brant
Modified: 2014-10-07 17:09 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dmitry Brant 2014-08-08 16:39:49 UTC
For example, the app has only one set of resources called "values-zh", whereas it should have (at least) two sets of resources for Simplified and Traditional Chinese.
Comment 1 Brion Vibber 2014-08-09 09:52:20 UTC
I ..... _think_ the dir names for zh-hans and zh-hant should be mapped to values-zh-rCN and values-zh-rTW but I'm not 100% sure this covers every possible locale.
Comment 2 Gerrit Notification Bot 2014-08-09 09:54:13 UTC
Change 153031 had a related patch set uploaded by Brion VIBBER:
Untested tweak for Chinese variants on Android app

https://gerrit.wikimedia.org/r/153031
Comment 3 Brion Vibber 2014-08-09 09:55:20 UTC
Something like the linked gerrit patch to TranslateWiki configuration may divert things to the right place. Totally untested, be warned!
Comment 4 Gerrit Notification Bot 2014-08-09 11:01:17 UTC
Change 153031 merged by jenkins-bot:
Untested tweak for Chinese variants on Android app

https://gerrit.wikimedia.org/r/153031
Comment 5 Brion Vibber 2014-08-09 11:05:02 UTC
Ok Siebrand went ahead and merged that as it looks right on their end. Let's test on the next update and confirm it works as expected...
Comment 6 Bernd Sitzmann 2014-08-11 21:49:18 UTC
Exported the strings from TWN to Android resources: https://gerrit.wikimedia.org/r/#/c/153472/1

It did generate the expected new Chinese variants in folder values-zh-rCN and values-zh-rTW.
We still have the old values-zh folder. I believe we should link that to values-zh-rCN.
The Android appcompat-v7 library also comes with a values-zh-rHK. I think this one should be linked to values-zh-rTW. Does this sound like a reasonable next step?
Comment 7 Gerrit Notification Bot 2014-08-11 21:49:27 UTC
Change 153472 had a related patch set uploaded by BearND:
Manual import of translations from TWN

https://gerrit.wikimedia.org/r/153472
Comment 8 Gerrit Notification Bot 2014-08-11 21:51:04 UTC
Change 153472 merged by jenkins-bot:
Manual import of translations from TWN

https://gerrit.wikimedia.org/r/153472
Comment 9 Gerrit Notification Bot 2014-08-12 00:14:18 UTC
Change 153548 had a related patch set uploaded by BearND:
Remove old Chinese default language variant

https://gerrit.wikimedia.org/r/153548
Comment 10 Gerrit Notification Bot 2014-08-12 00:14:23 UTC
Change 153549 had a related patch set uploaded by BearND:
Link default and HK Chinese language variant

https://gerrit.wikimedia.org/r/153549
Comment 11 Gerrit Notification Bot 2014-08-12 16:37:45 UTC
Change 153548 merged by Dbrant:
Remove old Chinese default language variant

https://gerrit.wikimedia.org/r/153548
Comment 12 Gerrit Notification Bot 2014-08-12 16:38:13 UTC
Change 153549 merged by Dbrant:
Link default and HK Chinese language variant

https://gerrit.wikimedia.org/r/153549
Comment 13 Gerrit Notification Bot 2014-08-12 23:40:44 UTC
Change 153729 had a related patch set uploaded by BearND:
More variants for Chinese and Hebrew

https://gerrit.wikimedia.org/r/153729
Comment 14 Bernd Sitzmann 2014-08-13 16:14:25 UTC
*** Bug 69457 has been marked as a duplicate of this bug. ***
Comment 15 Gerrit Notification Bot 2014-09-04 03:56:30 UTC
Change 153729 abandoned by BearND:
More variants for Chinese and Hebrew

Reason:
Don't need most of it. Will do a simple patch with just what I need.

https://gerrit.wikimedia.org/r/153729
Comment 16 Gerrit Notification Bot 2014-09-04 04:05:12 UTC
Change 158324 had a related patch set uploaded by BearND:
Map Simplified Chinese (zh-hans) to zh default

https://gerrit.wikimedia.org/r/158324
Comment 17 Gerrit Notification Bot 2014-10-06 10:52:12 UTC
Change 158324 merged by jenkins-bot:
Map Simplified Chinese (zh-hans) to zh default

https://gerrit.wikimedia.org/r/158324

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links