Last modified: 2014-08-09 00:11:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71316, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 69316 - Echo qunit tests break MobileFrontend tests
Echo qunit tests break MobileFrontend tests
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Echo (Other open bugs)
master
All All
: Unprioritized major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-08-09 00:01 UTC by Florian
Modified: 2014-08-09 00:11 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Chrome error console (49.93 KB, image/png)
2014-08-09 00:01 UTC, Florian 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Florian 2014-08-09 00:01:27 UTC 
Created attachment 16161 [details]
Chrome error console

The qunit tests, introduced in Echo, actually breaks qunit tests of MobileFrontend (if Echo is installed). Error message from console:
Uncaught Error: Unknown dependency: ext.echo.overlay (which loads only by desktop)

(see picture for more details)

Caused by: https://gerrit.wikimedia.org/r/#/c/151976/
(works with 0dc45e6c4ac1b8b918774376169f77214b0e11a3 [1], works not with 8d12ef9a8032854e5ecbef46cf4e2c0262285266 [2])

[1] https://github.com/wikimedia/mediawiki-extensions-Echo/commit/0dc45e6c4ac1b8b918774376169f77214b0e11a3#diff-d41d8cd98f00b204e9800998ecf8427e
[2] https://github.com/wikimedia/mediawiki-extensions-Echo/commit/8d12ef9a8032854e5ecbef46cf4e2c0262285266
Comment 1 Gerrit Notification Bot 2014-08-09 00:06:34 UTC 
Change 152999 had a related patch set uploaded by Jdlrobson:
Stop breaking MobileFrontend QUnit tests

https://gerrit.wikimedia.org/r/152999
Comment 2 Gerrit Notification Bot 2014-08-09 00:07:16 UTC 
Change 153000 had a related patch set uploaded by Florianschmidtwelzow:
Remove qunit tests from mobile

https://gerrit.wikimedia.org/r/153000
Comment 3 Gerrit Notification Bot 2014-08-09 00:08:53 UTC 
Change 153000 merged by jenkins-bot:
Remove qunit tests from mobile

https://gerrit.wikimedia.org/r/153000
Comment 4 Gerrit Notification Bot 2014-08-09 00:08:59 UTC 
Change 152999 abandoned by Jdlrobson:
Stop breaking MobileFrontend QUnit tests

Reason:
Florian's way was better.

https://gerrit.wikimedia.org/r/152999
Comment 5 Florian 2014-08-09 00:11:45 UTC 
Change https://gerrit.wikimedia.org/r/#/c/153000/1 merged, tested and ok -> Resolved
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links