Last modified: 2014-08-19 15:12:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71317, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 69317 - Interwiki prefixes that end in a URL protocol cannot be used as link= for file inclusions
Interwiki prefixes that end in a URL protocol cannot be used as link= for fil...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.24rc
All All
: Normal minor (vote)
: 1.24.0 release
Assigned To: This, that and the other (TTO)
https://it.wikipedia.org/wiki/Wikiped...
:
: 69486 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-08-09 01:03 UTC by FRacco
Modified: 2014-08-19 15:12 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description FRacco 2014-08-09 01:03:54 UTC 
Intention:
In Italian projects links to "wikinews:" do not work for images, "n:en:" is ok. Links [[wikinews:]] or [[n:en:]] are always ok.

Steps to Reproduce:
1. [[File:prova.jpg|link=wikinews:]] creates a link to the IMAGE PAGE, not to the English version of wikinews.
2. [[File:prova.jpg|link=n:en:]] creates a link to the English version of wikinews.
3. [[wikinews:]] or [[n:en:]] both create a link to the English version of wikinews.




Reproducible: Always
Comment 1 Andre Klapper 2014-08-16 10:57:25 UTC 
Could you provide a specific example for what's not working, plus the expected and the actual outcome? Thanks!
Comment 2 This, that and the other (TTO) 2014-08-16 11:49:39 UTC 
This is a strange bug. There appears to be some kind of conflict between the URL protocol "news:" and the interwiki prefix "wikinews".

If I define an interwiki prefix "foomagnet" (note that "magnet:" is a valid URL protocol in MediaWiki by default) then the same behaviour is seen on [[File:Prova.jpg|link=foomagnet:]].

Possibly the code that is supposed to prevent external links being used in the link= parameter is a bit overzealous.
Comment 3 Gerrit Notification Bot 2014-08-16 12:10:07 UTC 
Change 154399 had a related patch set uploaded by TTO:
Fix URL protocol detection regex for file link= parameter

https://gerrit.wikimedia.org/r/154399
Comment 4 Bartosz Dziewoński 2014-08-16 20:10:30 UTC 
*** Bug 69486 has been marked as a duplicate of this bug. ***
Comment 5 Gerrit Notification Bot 2014-08-18 15:34:36 UTC 
Change 154399 merged by jenkins-bot:
Fix URL protocol detection regex for file link= parameter

https://gerrit.wikimedia.org/r/154399
Comment 6 Gerrit Notification Bot 2014-08-18 16:22:57 UTC 
Change 154844 had a related patch set uploaded by Bartosz Dziewoński:
Fix URL protocol detection regex for file link= parameter

https://gerrit.wikimedia.org/r/154844
Comment 7 Gerrit Notification Bot 2014-08-18 16:23:18 UTC 
Change 154845 had a related patch set uploaded by Bartosz Dziewoński:
Fix URL protocol detection regex for file link= parameter

https://gerrit.wikimedia.org/r/154845
Comment 8 Gerrit Notification Bot 2014-08-19 15:03:57 UTC 
Change 154845 merged by jenkins-bot:
Fix URL protocol detection regex for file link= parameter

https://gerrit.wikimedia.org/r/154845
Comment 9 Gerrit Notification Bot 2014-08-19 15:10:01 UTC 
Change 154844 merged by jenkins-bot:
Fix URL protocol detection regex for file link= parameter

https://gerrit.wikimedia.org/r/154844
Comment 10 Bartosz Dziewoński 2014-08-19 15:12:04 UTC 
Fixed and deployed. Thanks everyone.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links