Last modified: 2014-08-09 19:09:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71347, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 69347 - JSDuck tests don't run for .css file changes on Jenkins, but they process .css files when ran, making it possible to break master
JSDuck tests don't run for .css file changes on Jenkins, but they process .cs...
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
wmf-deployment
All All
: Unprioritized normal (vote)
: ---
Assigned To: Addshore
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-08-09 14:54 UTC by Bartosz Dziewoński
Modified: 2014-08-09 19:09 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Bartosz Dziewoński 2014-08-09 14:54:03 UTC 
JSDuck tests don't run for .css file changes on Jenkins, but when they do run for .js file changes, they also process .css files and the documentation comments in them.

For example, this commit broke master despite passing all tests: https://gerrit.wikimedia.org/r/#/c/152933/ and this one was needed to fix it: https://gerrit.wikimedia.org/r/#/c/153076/ (see earlier patchsets for tests).
Comment 1 Gerrit Notification Bot 2014-08-09 16:38:10 UTC 
Change 153120 had a related patch set uploaded by Addshore:
Also run JsDuck on *.css files

https://gerrit.wikimedia.org/r/153120
Comment 2 Gerrit Notification Bot 2014-08-09 19:09:08 UTC 
Change 153120 merged by jenkins-bot:
Also run JsDuck on *.css files

https://gerrit.wikimedia.org/r/153120
Comment 3 Antoine "hashar" Musso (WMF) 2014-08-09 19:09:57 UTC 
I have deployed Zuul configuration change.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links