Last modified: 2014-11-17 20:24:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71359, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69359 - VisualEditor: Label the "Remove" button in link inspector as "Cancel" if in link creation mode
VisualEditor: Label the "Remove" button in link inspector as "Cancel" if in l...
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Low enhancement
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-10 06:27 UTC by WhatamIdoing
Modified: 2014-11-17 20:24 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description WhatamIdoing 2014-08-10 06:27:09 UTC
For example, if you open the link tool on a blank page, there is nothing to "Remove" and nothing to "Open", so those buttons should be grayed out.
Comment 1 Alex Monk 2014-10-23 16:53:29 UTC
Open button was bug 70015
Comment 2 James Forrester 2014-10-23 17:51:46 UTC
(In reply to WhatamIdoing from comment #0)
> For example, if you open the link tool on a blank page, there is nothing to
> "Remove" and nothing to "Open", so those buttons should be grayed out.

1. Click into a blank spot (e.g. the cursor is at '|' in "Foo | Bar")
2. Enter a search term and select a link target

At this point, the only way to not insert this link is to click "Remove"; disabling it would mean that to not insert the link, you would have to empty the search box and then click "Done" (confusing) or outside the inspector (not possible in mobile).

Maybe we could come up with a different label, or maybe we don't care about this edge case enough?
Comment 3 Alex Monk 2014-11-17 00:13:10 UTC
Maybe relabel it "Cancel" instead in this case?
Comment 4 James Forrester 2014-11-17 20:24:27 UTC
(In reply to Alex Monk from comment #3)
> Maybe relabel it "Cancel" instead in this case?

Maybe.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links