Last modified: 2014-09-08 09:23:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71407, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69407 - VisualEditor: Consider whether exiting the link dialog in create mode should remove the link
VisualEditor: Consider whether exiting the link dialog in create mode should ...
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Low enhancement
: ---
Assigned To: Editing team bugs – take if you're interested!
: design
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-11 17:09 UTC by Arthur Rubin
Modified: 2014-09-08 09:23 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Arthur Rubin 2014-08-11 17:09:45 UTC
Re bug 68101

> Load VE. Say "Foobar" is the first word on the page.
> If you click on the link tool, by mistake or not, without selecting anything before, Foobar will automatically become a link to the Foobar page (it doesn't help that pressing ESC doesn't abort the action, the link gets applied anyway, as we know).

ESC _should not_ exit and save; it should either exit without saving, or revert the change (in this case, the link) without exiting.  I was going to set the Severity to "blocker", as it would block installation on en.Wikipedia, but that would be wrong.
Comment 1 James Forrester 2014-09-02 15:02:15 UTC
This is a mistaken understanding of what the button does, and what the window is for.

* The link button *creates* a link if there is none there already.
* Once the link is created, we then also pop up a link editing window 
* This is to let you change the link to point to a different place, or remove it.
* Pressing escape closes the editing window, leaving you with the link you created.

This is intentional design. Escape isn't "applying" anything, but it's probably not very clear. Maybe design would like to comment?
Comment 2 Liam Wyatt 2014-09-08 09:23:55 UTC
Unfortunately I agree with BOTH of you. 
I am often confused by the behaviour of the link dialogue and am often looking for the "insert" or "confirm" button. "Done" doesn't seem right to me somehow. 
On the other hand, James is right too. The behaviour of all the formatting icons on the toolbar is that as soon you press them, the action takes place. So, highlighting a word and pressing "bold" will cause the text to go bold immediately, not after a second 'confirmation click'. 
Nevertheless, despite intellectually understanding the link dialogue design, I keep stumbling on it - it gets in the way and I have to consciously think about it - which is not good behaviour for a labor-saving device.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links