Last modified: 2014-09-23 23:25:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71419, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69419 - MWMultiVersion can fatal for bad Host headers
MWMultiVersion can fatal for bad Host headers
Status: NEW
Product: Wikimedia
Classification: Unclassified
Deployment systems (Other open bugs)
wmf-deployment
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-12 00:44 UTC by Roan Kattouw
Modified: 2014-09-23 23:25 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2014-08-12 00:44:17 UTC
Saw the following in the fatal logs:

[2014-08-12 00:36:07] Fatal error: Invalid host name (wikipedia).
 at /usr/local/apache/common-local/multiversion/MWMultiVersion.php on line 360
Server: mw1091
Method: GET
URL: http://wikipedia/
Backtrace:
#0 /usr/local/apache/common-local/multiversion/MWMultiVersion.php(360): trigger_error('Invalid host na...', 256)
#1 /usr/local/apache/common-local/multiversion/MWMultiVersion.php(184): MWMultiVersion::error('Invalid host na...')
#2 /usr/local/apache/common-local/multiversion/MWMultiVersion.php(70): MWMultiVersion->setSiteInfoForWiki('wikipedia')
#3 /usr/local/apache/common-local/multiversion/MWVersion.php(31): MWMultiVersion::initializeForWiki('wikipedia')
#4 /usr/local/apache/common-local/w/index.php(3): getMediaWiki('index.php')
#5 {main}
Comment 1 Gerrit Notification Bot 2014-08-12 13:26:49 UTC
Change 153593 had a related patch set uploaded by Hashar:
multiversion: test we emit Invalid host name

https://gerrit.wikimedia.org/r/153593
Comment 2 Antoine "hashar" Musso (WMF) 2014-08-12 13:27:44 UTC
That is the expected behavior and has been around for a while.  The patch https://gerrit.wikimedia.org/r/#/c/153593/ adds a PHPUnit test for it.
Comment 3 Gerrit Notification Bot 2014-08-12 22:51:19 UTC
Change 153593 merged by jenkins-bot:
multiversion: test we emit Invalid host name

https://gerrit.wikimedia.org/r/153593
Comment 4 Antoine "hashar" Musso (WMF) 2014-08-13 07:18:50 UTC
The test that got merge above, just assert the current behavior.  We might want to throw / output something else for non-existing hostnames.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links