Last modified: 2014-08-19 22:44:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71432, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69432 - HTML code is seen while editing the ru.wikipedia page about Bohuslav Tablic
HTML code is seen while editing the ru.wikipedia page about Bohuslav Tablic
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Parsoid Team
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-12 12:00 UTC by Amir E. Aharoni
Modified: 2014-08-19 22:44 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Amir E. Aharoni 2014-08-12 12:00:18 UTC
Article URL: https://ru.wikipedia.org/wiki/%D0%A2%D0%B0%D0%B1%D0%BB%D0%B8%D1%86,_%D0%91%D0%BE%D0%B3%D1%83%D1%81%D0%BB%D0%B0%D0%B2

The infobox is shown correctly while reading the article, but broken when editing in VisualEditor. HTML code is shown above the page.
Comment 1 James Forrester 2014-08-12 12:18:49 UTC
Looks like [[ru:Template:Универсальная карточка]] is getting a bunch of content fostered out somewhere?
Comment 2 Amir E. Aharoni 2014-08-12 12:33:50 UTC
(In reply to James Forrester from comment #1)
> Looks like [[ru:Template:Универсальная карточка]] is getting a bunch of
> content fostered out somewhere?

I didn't go too deeply into the code, but it is build using this Lua module:
https://ru.wikipedia.org/wiki/Module:Universal_infocard

It pulls data from Wikidata, and seems to build tables using HTML rather than wiki table syntax. Maybe that is the cause.
Comment 3 Arlo Breault 2014-08-19 19:57:27 UTC
Fixed the template in,
https://ru.wikipedia.org/w/index.php?title=%D0%9C%D0%BE%D0%B4%D1%83%D0%BB%D1%8C%3AUniversal_infocard&diff=64929809&oldid=64897667

But we should be more robust against unclosed attributes.
Comment 4 Arlo Breault 2014-08-19 21:13:31 UTC
The template was returning something like,

  <table><tr><th style="text>great</th><td>"test</td></tr></table>

which parsoid rendered as,

  &lt;th style="text>great
  <table>
  <tbody>
  <tr>
  <td>"test</td></tr></tbody></table>

Looks like a bug in broken attribute heuristics.
Comment 5 Arlo Breault 2014-08-19 22:44:29 UTC
> Looks like a bug in broken attribute heuristics.

On second thought, I think what we're doing is fine. This is just broken wikitext.

The php parser gets away with it by refusing all "greater than" chars in attributes. ie.

  <div class="class>ey">stuff</div>

is rendered as,

  <div>ey"&gt;stuff</div>

which seems worse.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links