Last modified: 2014-08-15 14:50:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71468, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69468 - JS ReferenceErrors due to ResourceLoader changes
JS ReferenceErrors due to ResourceLoader changes
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Immediate blocker (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=frontend p=0
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-13 13:27 UTC by tobias.gritschacher
Modified: 2014-08-15 14:50 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description tobias.gritschacher 2014-08-13 13:27:57 UTC
We're getting a whole load of ReferenceErrors most likely caused by this change in core: https://gerrit.wikimedia.org/r/#/c/152122/
Comment 1 Krinkle 2014-08-13 16:16:45 UTC
Referenced from https://gerrit.wikimedia.org/r/#/c/152122/.

Can you provide more information about this Wikidata issue? What is the error message, call stack, steps to reproduce it?
Comment 2 tobias.gritschacher 2014-08-13 17:21:31 UTC
(In reply to Krinkle from comment #1)
> Referenced from https://gerrit.wikimedia.org/r/#/c/152122/.
> 
> Can you provide more information about this Wikidata issue? What is the
> error message, call stack, steps to reproduce it?

See e.g. here: http://wikidata.beta.wmflabs.org/wiki/Q21016?debug=true

If I undo the following changes it works fine again:
https://gerrit.wikimedia.org/r/#/c/152122/5/includes/resourceloader/ResourceLoader.php
https://gerrit.wikimedia.org/r/#/c/152122/5/resources/Resources.php
Comment 3 Gerrit Notification Bot 2014-08-14 13:13:52 UTC
Change 154050 had a related patch set uploaded by Tobias Gritschacher:
Remove ResourceLoader dependencies to jquery and mediawiki

https://gerrit.wikimedia.org/r/154050
Comment 5 Gerrit Notification Bot 2014-08-14 14:52:43 UTC
Change 154050 merged by jenkins-bot:
Remove ResourceLoader dependencies to jquery and mediawiki

https://gerrit.wikimedia.org/r/154050
Comment 6 Krinkle 2014-08-15 14:28:08 UTC
I've looked at that bug in different ways but all I've found is various hacks and inconsistencies in how they do things different in ways I can't find documentation of. One important thing that stood out (but might not be the only thing) is that wikidata extensions have a bunch of modules with a ResourceLoader dependency on "jquery" and/or "mediawiki" which is a recipe for disaster. There are core phpunit structure tests that point out this illegal dependency. It can cause the base namespaces to be redefined asynchronously, thus dereferencing any properties defined since (eg mw.config, mw.util, etc).
Comment 7 Aude 2014-08-15 14:50:29 UTC
we removed all the explicit dependencies on the mediawiki and jquery module and everything works again.

thanks Krinkle for helping debug this.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links