Last modified: 2014-09-17 18:36:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71475, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69475 - messages to logged-in user gone missing
messages to logged-in user gone missing
Status: RESOLVED DUPLICATE of bug 70855
Product: MobileFrontend
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
: browser-test-bug
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-13 14:56 UTC by Chris McMahon
Modified: 2014-09-17 18:36 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris McMahon 2014-08-13 14:56:50 UTC
Seen in beta labs: messages for user-already-logged-in and password-reset no longer appear. 

Please see the test failures in login.feature at https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox-sauce/150/testReport/  for details.
Comment 1 Bingle 2014-08-13 15:00:25 UTC
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/BWhN8M1K
Comment 2 Jon 2014-08-13 15:44:59 UTC
Either wrongly or rightly the desktop behaviour has changed

Going to http://127.0.0.1:8080/wiki/Special:Userlogin whilst logged in now redirects me to the main page.

As for password reset I'm seeing it but only when not logged in. I'm not sure why the test asserts Given I am logged in - why would you need to see a password reset in that situation?
Comment 3 Chris McMahon 2014-08-13 17:39:54 UTC
Possibly a by-blow of https://gerrit.wikimedia.org/r/#/c/148144/ according to Matthew Flaschen.  Reassigning this bug to Mediawiki not Mobile
Comment 4 Jon 2014-08-13 22:30:28 UTC
Please let's keep it as a MobileFrontend bug as this is where the tests are passing. Personally I think the new behaviour is correct and we simply need to update the tests
Comment 5 Jon 2014-08-13 22:30:45 UTC
failing rather... :)
Comment 6 Matthew Flaschen 2014-08-14 04:31:25 UTC
Followup, the change to redirect away from UserLogin if you're already logged in was indeed intentional.  See https://git.wikimedia.org/blob/mediawiki%2Fcore.git/00b69eee50556880678ae491ebfcc01ebca96259/includes%2Fspecials%2FSpecialUserlogin.php#L240

(In reply to Jon from comment #2)
> As for password reset I'm seeing it but only when not logged in. I'm not
> sure why the test asserts Given I am logged in - why would you need to see a
> password reset in that situation?

FWIW, I don't notice any behavior change on desktop for this.  It pre-fills the username, then lets you reset the password.

The only reason you would do this is if you were currently logged in, but had forgotten your password (you also need your current password to change your password).

However, this is an edge case.  If it doesn't behave that way on mobile, they have the option of logging out.  (If you don't have an email set, you're out of luck either way, since changing an email also requires a password).
Comment 7 Jon 2014-09-17 18:36:18 UTC

*** This bug has been marked as a duplicate of bug 70855 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links