Last modified: 2014-08-20 15:47:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71478, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 69478 - enable tab voting on DNS repo


Summary:	enable tab voting on DNS repo

Status:	RESOLVED FIXED

Product:	Wikimedia
Classification:	Unclassified
Component:	Continuous integration (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized enhancement (vote)
Target Milestone:	---
Assigned To:	Antoine "hashar" Musso (WMF)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-08-13 16:24 UTC by Daniel Zahn
Modified:	2014-08-20 15:47 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel Zahn 2014-08-13 16:24:18 UTC

Dear hashar,

recently you enabled tab voting in jenkins on the operations/puppet repo after we removed the last litereal tab chars. 

Could you enable the same for operations/dns? I have recently retabbed all zone files and also the template(s). 

grep -rP "\t" *

Merci beaucoup,

Daniel

Comment 1 Antoine "hashar" Musso (WMF) 2014-08-20 15:36:49 UTC

I have refactored the tabs job in Jenkins.  The command I ended up with is:

 echo "Looking for tabulations in files matching: {fileselector}"
         set -x
         (grep --recursive -P '^\t' --exclude-dir='.git' --include='{fileselector}' .) && HAS_TAB=1 || HAS_TAB=0
         exit $HAS_TAB

Comment 2 Gerrit Notification Bot 2014-08-20 15:37:12 UTC

Change 155277 had a related patch set uploaded by Hashar:
Create operations-dns-tabs

https://gerrit.wikimedia.org/r/155277

Comment 3 Gerrit Notification Bot 2014-08-20 15:37:56 UTC

Change 155278 had a related patch set uploaded by Hashar:
Trigger operations-dns-tabs

https://gerrit.wikimedia.org/r/155278

Comment 4 Gerrit Notification Bot 2014-08-20 15:42:35 UTC

Change 155278 merged by jenkins-bot:
Trigger operations-dns-tabs

https://gerrit.wikimedia.org/r/155278

Comment 5 Gerrit Notification Bot 2014-08-20 15:44:29 UTC

Change 155279 had a related patch set uploaded by Hashar:
Jenkins test for tabs

https://gerrit.wikimedia.org/r/155279

Comment 6 Gerrit Notification Bot 2014-08-20 15:46:22 UTC

Change 155277 merged by jenkins-bot:
Create operations-dns-tabs

https://gerrit.wikimedia.org/r/155277

Comment 7 Gerrit Notification Bot 2014-08-20 15:46:36 UTC

Change 155279 abandoned by Hashar:
Jenkins test for tabs

Reason:
All good :)

https://gerrit.wikimedia.org/r/155279

Comment 8 Antoine "hashar" Musso (WMF) 2014-08-20 15:47:15 UTC

It is all done now.

All related changes share the same change-id https://gerrit.wikimedia.org/r/#q,I4380de3f8a272462e44636f4543b2843c6df1f1a,n,z


The test change was https://gerrit.wikimedia.org/r/#/c/155279/

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links