Last modified: 2014-09-05 21:38:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71501, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69501 - VisualEditor: If 'summary' parameter is provided in URL, it should be the default edit summary
VisualEditor: If 'summary' parameter is provided in URL, it should be the def...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2014-09-04
Assigned To: Alex Monk
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-13 22:40 UTC by WhatamIdoing
Modified: 2014-09-05 21:38 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description WhatamIdoing 2014-08-13 22:40:39 UTC
This is related to bug 50872.

If you click the edit link on a section, then that section's heading is pre-populated in the edit summary when you save.

This does not work very well if you have turned on https://en.wikipedia.org/wiki/MediaWiki:Gadget-edittop.js ("Add an [edit] link for the lead section of a page") in the gadgets for your preferences.  Editing the first (lead) section of the page gets a suggested edit summary that includes the first section heading on the page i.e., the section heading immediately underneath the section you were actually editing.

The link for 'edit source' says:

https://en.wikipedia.org/w/index.php?title=User:WhatamIdoing&action=edit&section=0&summary=/*%20top%20*/%20 

The link for 'edit' says:

https://en.wikipedia.org/w/index.php?title=User:WhatamIdoing&veaction=edit&vesection=1

The subsequent section editing links are all correct.
Comment 1 Alex Monk 2014-08-14 00:25:57 UTC
It looks like the gadget needs to be fixed to deal with VE. In particular, it needs to be able to deal with 've' between the '&' and 'section='.
Comment 2 Alex Monk 2014-08-14 00:34:51 UTC
Although VE should probably pick up the default summary from the URL.
Comment 3 Gerrit Notification Bot 2014-08-28 01:57:06 UTC
Change 156744 had a related patch set uploaded by Alex Monk:
Pick up 'summary' parameter from URL to use as initial edit summary

https://gerrit.wikimedia.org/r/156744
Comment 4 Gerrit Notification Bot 2014-08-28 21:29:10 UTC
Change 156744 merged by jenkins-bot:
Pick up 'summary' parameter from URL to use as initial edit summary

https://gerrit.wikimedia.org/r/156744
Comment 5 Alex Monk 2014-09-05 21:38:29 UTC
I went back and fixed up that gadget so it should handle VE links correctly. This change to pick up 'summary' from the URL should take affect on all Wikipedias on Thursday (it should already be on test and test2).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links