Last modified: 2014-10-17 18:34:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71505, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69505 - Tests fail because they use deprecated assertTag and assertNotTag
Tests fail because they use deprecated assertTag and assertNotTag
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Unit tests (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-13 23:09 UTC by Ori Livneh
Modified: 2014-10-17 18:34 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ori Livneh 2014-08-13 23:09:19 UTC
PHPUnit_Framework_Assert::assertTag has been deprecated in PHPUnit 4.2. Because we configure our test runs to raise deprecation warnings as errors, PHPUnit considers the test run to have failed.

See <https://travis-ci.org/wikimedia/mediawiki-core/jobs/32487532> for an example.

See <https://github.com/sebastianbergmann/phpunit/issues/1292> for the discussion that led to the deprecation of the assert method.
Comment 1 Gerrit Notification Bot 2014-08-17 21:39:58 UTC
Change 154703 had a related patch set uploaded by Addshore:
Override phpunit assertTag method to stop errors

https://gerrit.wikimedia.org/r/154703
Comment 2 Gerrit Notification Bot 2014-08-17 21:45:14 UTC
Change 154703 merged by jenkins-bot:
Override phpunit assertTag method to stop errors

https://gerrit.wikimedia.org/r/154703
Comment 3 Gerrit Notification Bot 2014-10-17 18:16:43 UTC
Change 167242 had a related patch set uploaded by Hoo man:
Also provide assertNotTag in MediaWikiTestCase

https://gerrit.wikimedia.org/r/167242
Comment 4 Marius Hoch 2014-10-17 18:17:40 UTC
assertNotTag also is an issue for eg. Wikibase
Comment 5 Gerrit Notification Bot 2014-10-17 18:27:20 UTC
Change 167242 merged by jenkins-bot:
Also provide assertNotTag in MediaWikiTestCase

https://gerrit.wikimedia.org/r/167242

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links