Last modified: 2014-10-23 17:07:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71512, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69512 - VisualEditor: Too much tabbing in the Template dialog
VisualEditor: Too much tabbing in the Template dialog
Status: RESOLVED DUPLICATE of bug 68768
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Unprioritized minor
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-13 23:57 UTC by WhatamIdoing
Modified: 2014-10-23 17:07 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description WhatamIdoing 2014-08-13 23:57:12 UTC
From John Broughton:

"This is what tabbing through Cite templates (in the mini-editors) looks like: type, tab, tab, tab, type, tab, tab, tab, type, ... You have to tab three times to get from one field to the next. That's because tabbing always includes both the “Field description” and “Remove field” icons. There isn't any reason to include these icons in tabbing; tabbing should bypass these icons."
Comment 1 Derk-Jan Hartman 2014-08-21 13:47:53 UTC
Also shift tab behaves differently (this is due to presence of icon only in focus state. WAI-ARIA has some further thoughts on how bot build fields like this, but I think it might be a bit too much effort right now.)

Using an actual button might fix 'excessive' tabbing here, since browsers sometimes have different default tab behavior for buttons vs. fields, a behavior overridden if you need to force button behaviors on a div/a.
Comment 2 James Forrester 2014-08-21 17:38:05 UTC
(In reply to WhatamIdoing from comment #0)
> From John Broughton:

[…]

> There isn't any reason to include these icons in tabbing

The reason is "accessibility". That's a pretty strong sine qua non for how we build things.

(In reply to Derk-Jan Hartman from comment #1)
> Using an actual button might fix 'excessive' tabbing here, since browsers
> sometimes have different default tab behavior for buttons vs. fields, a
> behavior overridden if you need to force button behaviors on a div/a.

Using a <button> rather than a <div> in OOUI for buttoned elements takes us into really horrible issues more widely, though…
Comment 3 Derk-Jan Hartman 2014-08-22 08:32:22 UTC
(In reply to James Forrester from comment #2)
> Using a <button> rather than a <div> in OOUI for buttoned elements takes us
> into really horrible issues more widely, though…

Can you elaborate, because I don't see why that would be ? We have gotten them pretty down even in mediawiki.ui
Comment 4 Alex Monk 2014-10-23 17:07:40 UTC

*** This bug has been marked as a duplicate of bug 68768 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links